Skip to content

pacific: os/bluestore: fix onode ref counting#50072

Merged
yuriw merged 7 commits intoceph:pacificfrom
ifed01:wip-ifed-more-pin-fix-pac
Apr 5, 2023
Merged

pacific: os/bluestore: fix onode ref counting#50072
yuriw merged 7 commits intoceph:pacificfrom
ifed01:wip-ifed-more-pin-fix-pac

Conversation

@ifed01
Copy link
Contributor

@ifed01 ifed01 commented Feb 10, 2023 •
edited
Loading

backport of #47702

backport tracker: https://tracker.ceph.com/issues/58676
parent tracker: https://tracker.ceph.com/issues/56382
Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

ifed01 and others added 7 commits February 10, 2023 18:14
@ifed01
os/bluestore: rename Collection::onode_map to onode_space
d261916 
to ease code reading.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 0c02f3e)
@ifed01
os/bluestore: minor refactoring around OnodeSpace struct to improve code
816b4fc 
readability.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 3df4a8d)

 Conflicts:
	src/os/bluestore/BlueStore.cc
	src/os/bluestore/BlueStore.h
 <lack of ceph#46036 backporting>
@ifed01
os/bluestore: avoid duplicate lookup when adding entry to OnodeSpace
980f96e 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 7eed358)
@ifed01
os/bluestore: fix onode ref counting
4a80641 
This should eliminate duplicate onode releases that could happen before.
Additionally onode pinning is performed during cache trimming not onode
ref count increment.

[Hopefully] fixes: https://tracker.ceph.com/issues/53002

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit a3057f4)

 Conflicts:
	src/os/bluestore/BlueStore.cc
	src/os/bluestore/BlueStore.h
 <lack of ceph#46036 and
  ceph#43299 backporting>
@ifed01
os/bluestore: unify OnodeRef usage
bacbbc8 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 3b40c5c)

 Ponflicts:
       src/os/bluestore/BlueStore.cc
       src/os/bluestore/BlueStore.h
 <lack of ceph#45805 backporting>
@ifed01
os/bluestore: simplify onode cache trimming
61d094d 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 5aaa2e0)

 Conflicts:
	src/os/bluestore/BlueStore.cc
 <no backport for ceph#43299>
@ifed01
os/bluestore: touch onode in cache LRU explicitly.
e5d9afc 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 1d4abf7)

  Conflicts:
    src/os/bluestore/BlueStore.cc
  <no bacport for ceph#43299>
@ifed01 ifed01 requested a review from a team as a code owner February 10, 2023 16:14
@ifed01 ifed01 requested a review from aclamk February 10, 2023 16:14
@github-actions github-actions bot added this to the pacific milestone Feb 10, 2023
@ifed01
Copy link
Contributor Author

ifed01 commented Feb 13, 2023

jenkins test api

aclamk
aclamk approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@aclamk aclamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@kfox1111
Copy link

kfox1111 commented Mar 17, 2023

Any movement on this?

@zhucan
Copy link

zhucan commented Mar 20, 2023

what's the progress？ and the release time of v16.2.12 is?

@ljflores
Copy link
Member

ljflores commented Apr 5, 2023

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri6-testing-2023-03-12-0918-pacific

Failures, unrelated:
1. https://tracker.ceph.com/issues/59192
2. https://tracker.ceph.com/issues/58560
3. https://tracker.ceph.com/issues/59127
4. https://tracker.ceph.com/issues/58560
5. https://tracker.ceph.com/issues/54071
6. https://tracker.ceph.com/issues/57386
7. https://tracker.ceph.com/issues/49525
8. https://tracker.ceph.com/issues/57255

Details:
1. cls/test_cls_sdk.sh: Health check failed: 1 pool(s) do not have an application enabled (POOL_APP_NOT_ENABLED) - Ceph - RADOS
2. rook: failed to pull kubelet image - Ceph - Orchestrator
3. Job that normally complete much sooner last almost 12 hours
4. test_envlibrados_for_rocksdb.sh failed to subscribe to repo - Infrastructure
5. rados/cephadm/osds: Invalid command: missing required parameter hostname() - Ceph - Orchestrator
6. cephadm/test_dashboard_e2e.sh: Expected to find content: '/^foo$/' within the selector: 'cd-modal .badge' but never did - Ceph - Mgr - Dashboard
7. found snap mapper error on pg 3.2s1 oid 3:4abe9991:::smithi10121515-14:e4 snaps missing in mapper, should be: dc was r -2...repaired - Ceph - RADOS
8. rados/cephadm/mds_upgrade_sequence, pacific : cephadm [ERR] Upgrade: Paused due to UPGRADE_NO_STANDBY_MGR: Upgrade: Need standby mgr daemon - Ceph - Orchestrator

@yuriw yuriw merged commit 13aa0d6 into ceph:pacific Apr 5, 2023
@ifed01 ifed01 deleted the wip-ifed-more-pin-fix-pac branch April 5, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclamk aclamk aclamk approved these changes

Assignees

No one assigned

Labels

backport bluestore bug-fix needs-qa wip-yuri6-testing

Projects

None yet

Milestone

pacific

Development

Successfully merging this pull request may close these issues.

6 participants

@ifed01 @kfox1111 @zhucan @ljflores @aclamk @yuriw