Skip to content

os/bluestore: more debug information from BlueStore#45805

Merged
yuriw merged 2 commits intoceph:masterfrom
ifed01:wip-ifed-more-stats
May 24, 2022
Merged

os/bluestore: more debug information from BlueStore#45805
yuriw merged 2 commits intoceph:masterfrom
ifed01:wip-ifed-more-stats

Conversation

@ifed01
Copy link
Contributor

@ifed01 ifed01 commented Apr 6, 2022 •
edited
Loading

This includes more verbose bluefs stats command output in ceph-bluestore-tool and a bunch of new omap-related performance counters

Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@ifed01 ifed01 requested review from aclamk and markhpc April 6, 2022 20:33
aclamk
aclamk requested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@aclamk aclamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valueable addition.
I have questions that might or might not be a change requests.

@ifed01 ifed01 force-pushed the wip-ifed-more-stats branch from b89bbc2 to dc4e273 Compare April 21, 2022 15:29
aclamk
aclamk approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@aclamk aclamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ifed01 ifed01 force-pushed the wip-ifed-more-stats branch from dc4e273 to 5456dca Compare April 25, 2022 10:32
@github-actions
Copy link

github-actions bot commented Apr 26, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

ifed01 added 2 commits April 27, 2022 19:58
@ifed01
tool/bluestore_tool: make 'bluefs-stats' command dump per-dev stats.
3cb11af 
Originally the command uses default volume selector for stats collection
 which isn't that verbose when single volume is in use. This patch
enforces using RocksDBBlueFSVolumeSelector to dump more stats.
Additionally one can enforce that selector usage via config parameters.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01
os/bluestore: more omap-related perf counters
3c6a721 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01 ifed01 force-pushed the wip-ifed-more-stats branch from 5456dca to 3c6a721 Compare April 27, 2022 16:59
@ljflores
Copy link
Member

ljflores commented May 23, 2022

http://pulpito.front.sepia.ceph.com/yuriw-2022-05-19_01:43:57-rados-wip-yuri7-testing-2022-05-18-1636-distro-default-smithi/

Failures, unrelated:
1. https://tracker.ceph.com/issues/52124
2. https://tracker.ceph.com/issues/55741
3. https://tracker.ceph.com/issues/51835
4. https://tracker.ceph.com/issues/52321

Details:
1. Invalid read of size 8 in handle_recovery_delete() - Ceph - RADOS
2. cephadm/test_dashboard_e2e.sh: Unable to find element cd-modal .custom-control-label when testing on orchestrator/01-hosts.e2e-spec.ts - Ceph - Mgr - Dashboard
3. mgr/DaemonServer.cc: FAILED ceph_assert(pending_service_map.epoch > service_map.epoch) - Ceph - RADOS
4. qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Ceph - Orchestrator

@ljflores
Copy link
Member

ljflores commented May 23, 2022

jenkins test api

@yuriw yuriw merged commit 714cdc4 into ceph:master May 24, 2022
@ifed01 ifed01 deleted the wip-ifed-more-stats branch May 25, 2022 09:57
ifed01 added a commit to ifed01/ceph that referenced this pull request Feb 10, 2023
@ifed01
os/bluestore: unify OnodeRef usage
bacbbc8 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 3b40c5c)

 Ponflicts:
       src/os/bluestore/BlueStore.cc
       src/os/bluestore/BlueStore.h
 <lack of ceph#45805 backporting>
mkogan1 pushed a commit to mkogan1/ceph that referenced this pull request Mar 25, 2024
@ifed01 @aclamk
os/bluestore: unify OnodeRef usage
5c4b15c 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 3b40c5c)

 Ponflicts:
       src/os/bluestore/BlueStore.cc
       src/os/bluestore/BlueStore.h
 <lack of ceph#45805 backporting>

(cherry picked from commit bacbbc8)

Resolves: rhbz#2218445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclamk aclamk aclamk approved these changes

@markhpc markhpc Awaiting requested review from markhpc

Assignees

No one assigned

Labels

bluestore common core feature needs-qa wip-yuri7-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ifed01 @ljflores @aclamk @yuriw