mds/events/EImport{Finish,Start}.h: fix print()#49
Closed
dalgaaf wants to merge 1 commit intoceph:masterfrom
dalgaaf:wip-da-sca-clang-overloaded-virt
Closed
mds/events/EImport{Finish,Start}.h: fix print()#49dalgaaf wants to merge 1 commit intoceph:masterfrom dalgaaf:wip-da-sca-clang-overloaded-virt
dalgaaf wants to merge 1 commit intoceph:masterfrom
dalgaaf:wip-da-sca-clang-overloaded-virt
Conversation
Fix -Woverloaded-virtual warning from clang++. Remove 'const'
from print() in derived classes.
mds/events/EImportStart.h:43:8: warning: 'EImportStart::print'
hides overloaded virtual function [-Woverloaded-virtual]
void print(ostream& out) const {
^
mds/events/../LogEvent.h:95:16: note: hidden overloaded virtual
function 'LogEvent::print' declared here
virtual void print(ostream& out) {
^
In file included from mds/journal.cc:31:
mds/events/EImportFinish.h:35:8: warning: 'EImportFinish::print'
hides overloaded virtual function [-Woverloaded-virtual]
void print(ostream& out) const {
^
mds/events/../LogEvent.h:95:16: note: hidden overloaded
virtual function 'LogEvent::print' declared here
virtual void print(ostream& out) {
^
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Member
|
Instead of removing the const flag from those classes, we should probably add it to the rest of them. const-correctness hurray! :) Would you like to do that, or shall I? |
Contributor
Author
|
I will change it that way and will fill a new pull request. Thanks for the comment |
XinzeChi
pushed a commit
to XinzeChi/ceph
that referenced
this pull request
Jan 29, 2016
os: add a field indicate xattr only one chunk for set xattr.
ddiss
pushed a commit
to ddiss/ceph
that referenced
this pull request
Oct 25, 2016
rpm: build of ceph-test package disabled by default Reviewed-by: Nathan Cutler <ncutler@suse.com>
tchaikov
pushed a commit
to tchaikov/ceph
that referenced
this pull request
Jun 3, 2017
Wip mgr stats
rjfd
added a commit
to rjfd/ceph
that referenced
this pull request
Jan 30, 2018
mgr/dashboard_v2: Fix pylint errors exposed in python 2.7
galsalomon66
referenced
this pull request
in galsalomon66/ceph
Sep 17, 2022
* s3select: CASE statement used to match conditions Signed-off-by: Albin Antony <aantony@redhat.com> * adding support for case-value-when-then; need to validate correct behavior upon nested functions Signed-off-by: gal salomon <gal.salomon@gmail.com> * fix typo Signed-off-by: Albin Antony <aantony@redhat.com> * tests Signed-off-by: Albin Antony <aantony@redhat.com> Co-authored-by: gal salomon <gal.salomon@gmail.com>
jecluis
pushed a commit
to jecluis/ceph
that referenced
this pull request
Oct 10, 2022
rgw/sfs: Get user by access_key when user has multiple keys
tobias-urdin
pushed a commit
to tobias-urdin/ceph
that referenced
this pull request
Aug 2, 2023
Copy tests for non-existent buckets and keys Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
athanatos
pushed a commit
to athanatos/ceph
that referenced
this pull request
Feb 14, 2025
PriorityQueueBase uses RequestRef&& for remove_by callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix -Woverloaded-virtual warning from clang++. Remove 'const'
from print() in derived classes.
mds/events/EImportStart.h:43:8: warning: 'EImportStart::print'
hides overloaded virtual function [-Woverloaded-virtual]
void print(ostream& out) const {
^
mds/events/../LogEvent.h:95:16: note: hidden overloaded virtual
function 'LogEvent::print' declared here
virtual void print(ostream& out) {
^
In file included from mds/journal.cc:31:
mds/events/EImportFinish.h:35:8: warning: 'EImportFinish::print'
hides overloaded virtual function [-Woverloaded-virtual]
void print(ostream& out) const {
^
mds/events/../LogEvent.h:95:16: note: hidden overloaded
virtual function 'LogEvent::print' declared here
virtual void print(ostream& out) {
^