Skip to content

crimson/osd: Support snapshot rollbacks #48756

Merged
Matan-B merged 4 commits intoceph:mainfrom
Matan-B:wip-matanb-rollback-snap
Jan 11, 2023
Merged

crimson/osd: Support snapshot rollbacks #48756
Matan-B merged 4 commits intoceph:mainfrom
Matan-B:wip-matanb-rollback-snap

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Nov 6, 2022 •
edited
Loading 

test_rados.TestIoCtxSelfManagedSnaps.test ... ok     
test_rados.TestIoctx.test_snap_rollback ... ok 
test_rados.TestIoctx.test_snap_rollback_removed ... ok
                                          
----------------------------------------------------------------------
Ran 3 tests in 19.729s 
                                            
OK 

$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshotseed 480475                        
Note: Google Test filter = TestLibRBD.TestIOToSnapshot                                                                                                                                        
[==========] Running 1 test from 1 test suite.                                                                                                                                                
[----------] Global test environment set-up.                                                                                                                                                  
[----------] 1 test from TestLibRBD                                                                                                                                                           
[ RUN      ] TestLibRBD.TestIOToSnapshot
[       OK ] TestLibRBD.TestIOToSnapshot (7290 ms)
[----------] 1 test from TestLibRBD (7290 ms total)
...
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8217 ms total)
[  PASSED  ] 1 test.

Blocked by: #48682

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B Matan-B added the DNM label Nov 6, 2022
@Matan-B Matan-B mentioned this pull request Nov 6, 2022
Merged
14 tasks
@Matan-B Matan-B force-pushed the wip-matanb-rollback-snap branch from 05fc299 to 7b5085a Compare November 9, 2022 10:36
@Matan-B Matan-B force-pushed the wip-matanb-rollback-snap branch from 7b5085a to 0729ed7 Compare November 9, 2022 10:37
@Matan-B Matan-B removed the build/ops label Nov 9, 2022
@Matan-B Matan-B force-pushed the wip-matanb-rollback-snap branch from 0729ed7 to ae87537 Compare November 13, 2022 14:23
@Matan-B
Copy link
Contributor Author

Matan-B commented Nov 30, 2022

jenkins test make check

@Matan-B Matan-B marked this pull request as ready for review November 30, 2022 09:52
@Matan-B Matan-B requested a review from a team as a code owner November 30, 2022 09:52
@Matan-B Matan-B changed the title [DNM] crimson/osd: Support snapshot rollbacks crimson/osd: Support snapshot rollbacks Nov 30, 2022
@Matan-B Matan-B requested a review from athanatos November 30, 2022 09:55
athanatos
athanatos requested changes Dec 6, 2022
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-rollback-snap branch 3 times, most recently from 625d810 to 671895c Compare December 14, 2022 17:32
rzarzynski
rzarzynski reviewed Dec 14, 2022
View reviewed changes
@Matan-B Matan-B requested a review from rzarzynski December 15, 2022 10:06
@Matan-B Matan-B mentioned this pull request Dec 29, 2022
Merged
20 tasks
@Matan-B Matan-B force-pushed the wip-matanb-rollback-snap branch 2 times, most recently from 611923f to eca5690 Compare January 3, 2023 13:26
@Matan-B Matan-B removed the DNM label Jan 3, 2023
Matan-B added 4 commits January 3, 2023 13:47
@Matan-B
crimson/osd: support snapshot rollbacks
66e9cc4 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
test/pybind/test_rados.py: add another rollback test
17a46d5 
Added another rollback test case:
Do not remove the original object to be rollbacked to.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
qa/suites/crimson-rados: rados_python - enable rollback test
314ffcb 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson/osd/pg_backend: missing modified_ranges implementataion tracker
8d706f1 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-rollback-snap branch from eca5690 to 8d706f1 Compare January 3, 2023 13:47
@Matan-B
Copy link
Contributor Author

Matan-B commented Jan 11, 2023

Merging based on:
https://pulpito.ceph.com/matan-2023-01-11_14:07:51-crimson-rados-wip-matanb-crimson-testing-2.10-v2-distro-crimson-smithi/

@Matan-B Matan-B merged commit ed40923 into ceph:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athanatos athanatos athanatos approved these changes

@rzarzynski rzarzynski Awaiting requested review from rzarzynski

Assignees

No one assigned

Labels

crimson tests wip-matan-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matan-B @athanatos @rzarzynski