crimson/osd: Introduce ObjectContextLoader#48682
Merged
Conversation
05340b1 to
b4a6d88
Compare
14 tasks
e22edf1 to
ee99154
Compare
ee99154 to
d3ead10
Compare
d3ead10 to
9b76fcb
Compare
rzarzynski
approved these changes
Nov 8, 2022
9b76fcb to
139d057
Compare
Contributor
|
Sorry, I meant that this bit should be pulled into an ObjectContextLoader method -- probably notify_on_change(bool primary). |
Contributor
|
/home/jenkins-build/build/workspace/ceph-pull-requests/src/crimson/osd/object_context_loader.cc:42:35: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] |
139d057 to
054ee19
Compare
athanatos
approved these changes
Nov 15, 2022
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
* obc load logic is moved to a seperate class for better reusability. * with_existing_* logic is removed. (not being used) Signed-off-by: Matan Breizman <mbreizma@redhat.com>
obc_set_accessing is owned by ObjectContextLoader and is removed from PG. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
A with_clone_obc() variant, in PGBackend::rollback() with_locked_obc is locking the head obc used, we should not lock the head object obc again (as in by calling with_head_obc()). Signed-off-by: Matan Breizman <mbreizma@redhat.com>
The head or clone branch seperation can be done later on (in with_obc()). Signed-off-by: Matan Breizman <mbreizma@redhat.com>
054ee19 to
7f73a7e
Compare
liu-chunmei
approved these changes
Nov 23, 2022
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object context load logic is moved to a separate class for better reusability.
with_existing_* / get_locked functions are removed. (not being used)
PG::resolve_oid() is moved to object_context.
Introduce with_clone_obc_only() (See ad1208f).
PG::with_locked_obc() do not distinguish bewtween head/clone
Example usage: #48756
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows