Skip to content

mgr: Remove service_daemon handling from MMgrUpdate#46838

Merged
yuriw merged 2 commits intoceph:mainfrom
pdvian:wip-version-mgrupdate
Aug 3, 2022
Merged

mgr: Remove service_daemon handling from MMgrUpdate#46838
yuriw merged 2 commits intoceph:mainfrom
pdvian:wip-version-mgrupdate

Conversation

@pdvian
Copy link
Contributor

@pdvian pdvian commented Jun 24, 2022 •
edited
Loading

The service_daemon is only required if client services
needs to be registered with mgr. The service_daemon
handling is not required in case of MMgrUpdate as it
handles mon metadata updates only.

Fixes: https://tracker.ceph.com/issues/55322

Signed-off-by: Prashant D pdhange@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

mgr: Remove service_daemon handling from MMgrUpdate
6540937 
The service_daemon is only required if client services
needs to be registered with mgr. The service_daemon
handling is not required in case of MMgrUpdate as it
handles mon metadata updates only.

Fixes: https://tracker.ceph.com/issues/55322

Signed-off-by: Prashant D <pdhange@redhat.com>
@pdvian pdvian requested a review from a team as a code owner June 24, 2022 15:27
@pdvian pdvian added the DNM label Jun 24, 2022
@ljflores
Copy link
Member

ljflores commented Jun 24, 2022

I will be running some reproducer tests for the restful module bug.

Shaman build here: https://shaman.ceph.com/builds/ceph/wip-version-mgrupdate/

ljflores
ljflores reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@ljflores ljflores left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news @pdvian, the restful test is passing now! (See the latest note on the Tracker). We should still inspect the mgr logs to see if the new MMgrUpdate message is behaving as expected; plus, MMgrUpdate still needs to be added to tools/ceph-dencoder/common_types.h.

@ljflores ljflores added needs-quincy-backport backport required for quincy needs-pacific-backport PR needs a pacific backport labels Jun 27, 2022
@ljflores
tools/ceph-dencoder: add MMgrUpdate to ceph-dencoder tool
e2ddf9f 
Signed-off-by: Laura Flores <lflores@redhat.com>
@ljflores
Copy link
Member

ljflores commented Jul 5, 2022

jenkins test make check arm64

@ljflores
Copy link
Member

ljflores commented Jul 12, 2022

jenkins test make check arm64

@pdvian
Copy link
Contributor Author

pdvian commented Jul 15, 2022

The pacific upgrade tests were successful and failures are not related to PR#46838 (or prometheus upgrade test)
http://pulpito.front.sepia.ceph.com/pdhange-2022-07-15_00:43:02-upgrade:pacific-x:stress-split-wip-pdhange-testing-distro-default-smithi/

@pdvian pdvian removed the DNM label Jul 15, 2022
@pdvian
Copy link
Contributor Author

pdvian commented Jul 15, 2022

FYI used pacific upgrade testcase from #47024 to test this PR.

@ljflores
Copy link
Member

ljflores commented Jul 15, 2022

@yuriw can you add this to your next batch?

@kamoltat
Copy link
Member

kamoltat commented Aug 3, 2022

@yuriweinstein Rados approved

Related Failures:

/a/yuriw-2022-07-22_03:30:40-rados-wip-yuri3-testing-2022-07-21-1604-distro-default-smithi/6943775

due to ceph/ceph: Pull Request 46036

Unrelated Failures already with Tracker:
Bug #52124: Invalid read of size 8 in handle_recovery_delete() - RADOS - Ceph
Bug #52321: qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Orchestrator - Ceph
Bug #56652: cephadm/test_repos.sh: rllib.error.HTTPError: HTTP Error 504: Gateway Timeout - Orchestrator - Ceph
Bug #55001: rados/test.sh: Early exit right after LibRados global tests complete - RADOS - Ceph
Bug #53768: timed out waiting for admin_socket to appear after osd.2 restart in thrasher/defaults workload/small-objects - crimson - Ceph
Bug #48819: fsck error: found stray (per-pg) omap data on omap_head - bluestore - Ceph
Bug #55853: test_cls_rgw.sh: failures in 'cls_rgw.index_list' and 'cls_rgw.index_list_delimited` - rgw - Ceph
Bug #52652: ERROR: test_module_commands (tasks.mgr.test_module_selftest.TestModuleSelftest) - mgr - Ceph
Bug #55142: [ERR] : Unhandled exception from module 'devicehealth' while running on mgr.gibba002.nzpbzu: disk I/O error - cephsqlite - Ceph
Bug #44587: failed to write to cgroup.procs: - Orchestrator - Ceph
Bug #56716: RuntimeError: ceph version 16.2.10-515.g3bc1d6b2 was not installed, found 16.2.10-513.gc2f1041a.el8. - teuthology - Ceph

Unrelated Failures without Tracker:
Bug #57015: bluestore::NCB::__restore_allocator::No Valid allocation info on disk (empty file) - RADOS - Ceph
Infrastructure: Bug #56717: The package cache file is corrupted - teuthology - Ceph

@yuriw yuriw merged commit 9a792f6 into ceph:main Aug 3, 2022
This was referenced Aug 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljflores ljflores ljflores left review comments

@badone badone badone approved these changes

Assignees

No one assigned

Labels

core mgr needs-pacific-backport PR needs a pacific backport needs-qa needs-quincy-backport backport required for quincy wip-pdhange-testing wip-yuri3-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdvian @ljflores @kamoltat @badone @yuriw