upgrade/pacific-x/stress-split: Add prometheus metrics test#47024
upgrade/pacific-x/stress-split: Add prometheus metrics test#47024
Conversation
|
This upgrade testcase is intended for quincy release. Adding DNM till PR #45382 gets merged to main. |
70d28bc to
ac5ec6e
Compare
ac5ec6e to
d551201
Compare
|
jenkins test make check |
ljflores
left a comment
There was a problem hiding this comment.
Did you mean upgrade/pacifix-x/stress-split in your PR title, or did you mean to push parallel tests?
On partial/full cluster upgrade, the prometheus metrics was not reflecting the correct ceph version for the upgraded MONs. This upgrade testcase will verify that metrics reflecting correct ceph version for MONs. Signed-off-by: Prashant D <pdhange@redhat.com>
d551201 to
1912063
Compare
It should be |
|
jenkins test make check |
| @@ -0,0 +1,43 @@ | |||
| #!/bin/sh -ex | |||
There was a problem hiding this comment.
There is a lot of piping in this script (to jq, grep, etc). Lots of things could fail in these pipes. Bash has set -o pipefail - do we have to use /bin/sh here or can this be a full bash script?
epuertat
left a comment
There was a problem hiding this comment.
If we want this test (or similar one) to stop regressions like the 17.2.6's, then we could also add these 2 gates:
- An OpenMetrics format linter: to ensure that metrics, comments, and overall syntax meets the OpenMetrics format. This should run against both
mgr/prometheusandceph-exporter/metricsendpoint. - Metric names snapshot (similar to this): to detect regressions on specific metrics names, we should compare metrics names from
mgr/prometheusandceph-exporter/metricsendpoints with a saved snapshot. Since some metrics names could be missing depending on the type of daemons available in the testbed, we could try to ensure that at least the metrics used in Grafana PromQL queries are validated.
None of the above actually check the values of any metric, as for example this PR does.
What do you think @nizamial09 , @pereman2 , @avanthakkar ?
|
@epuertat Yup, I think integration testing on the prometheus endpoints should be done one time and let the endpoint be configured as we want to test the exporter with the same testing infra. About OpenMetrics, I think it is a good idea but let's hope we don't have lots of metrics not conforming to it :P. Btw @pdvian thanks for the patch. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
On partial/full cluster upgrade, the prometheus metrics
was not reflecting the correct ceph version for the
upgraded MONs. This upgrade testcase will verify
that metrics reflecting correct ceph version for MONs.
Signed-off-by: Prashant D pdhange@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows