quincy: mgr/dashboard: unselect rows in datatables #46323
Merged
epuertat merged 1 commit intoceph:quincyfrom May 31, 2022
Merged
quincy: mgr/dashboard: unselect rows in datatables #46323epuertat merged 1 commit intoceph:quincyfrom
epuertat merged 1 commit intoceph:quincyfrom
Conversation
Fixes: https://tracker.ceph.com/issues/53244 Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com> (cherry picked from commit b79e2a6)
avanthakkar
approved these changes
May 19, 2022
aaSharma14
approved these changes
May 19, 2022
Member
|
@Sarthak0702 you need to trigger dashboard and cephadm tests here. It's not enough with the "jenkins test ..." thing, you first have to rename your PR (just add a trailing whitespace). I'll do that for you this time ;-) |
Member
|
jenkins test dashboard |
Member
|
Confirmed: it doesn't work. Now let's rename the PR. |
Member
|
jenkins test dashboard |
Member
|
There they go |
Member
|
jenkins test dashboard cephadm |
Member
Author
|
@epuertat Thanks for this.! |
Member
Author
|
jenkins test dashboard cephadm |
3 similar comments
Member
Author
|
jenkins test dashboard cephadm |
Member
Author
|
jenkins test dashboard cephadm |
Member
|
jenkins test dashboard cephadm |
nizamial09
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Sep 4, 2022
…er found it This looks related to ceph#46323, but i am not sure why it started failing recently in the teuthology. The error is fixed by deselecting the row manually, so that it won't accidentally get deselected when we actually want it to select it. Fixes: https://tracker.ceph.com/issues/57207 Signed-off-by: Nizamudeen A <nia@redhat.com>
14 tasks
nizamial09
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Sep 16, 2022
…er found it This looks related to ceph#46323, but i am not sure why it started failing recently in the teuthology. The error is fixed by deselecting the row manually, so that it won't accidentally get deselected when we actually want it to select it. Fixes: https://tracker.ceph.com/issues/57207 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit dcbf179)
nizamial09
added a commit
to rhcs-dashboard/ceph
that referenced
this pull request
Sep 16, 2022
…er found it This looks related to ceph#46323, but i am not sure why it started failing recently in the teuthology. The error is fixed by deselecting the row manually, so that it won't accidentally get deselected when we actually want it to select it. Fixes: https://tracker.ceph.com/issues/57207 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit dcbf179)
zalsader
pushed a commit
to zalsader/ceph
that referenced
this pull request
Sep 19, 2022
…er found it This looks related to ceph#46323, but i am not sure why it started failing recently in the teuthology. The error is fixed by deselecting the row manually, so that it won't accidentally get deselected when we actually want it to select it. Fixes: https://tracker.ceph.com/issues/57207 Signed-off-by: Nizamudeen A <nia@redhat.com>
Pegonzal
pushed a commit
that referenced
this pull request
Sep 21, 2022
…er found it This looks related to #46323, but i am not sure why it started failing recently in the teuthology. The error is fixed by deselecting the row manually, so that it won't accidentally get deselected when we actually want it to select it. Fixes: https://tracker.ceph.com/issues/57207 Signed-off-by: Nizamudeen A <nia@redhat.com>
Pegonzal
pushed a commit
that referenced
this pull request
Oct 13, 2022
…er found it This looks related to #46323, but i am not sure why it started failing recently in the teuthology. The error is fixed by deselecting the row manually, so that it won't accidentally get deselected when we actually want it to select it. Fixes: https://tracker.ceph.com/issues/57207 Signed-off-by: Nizamudeen A <nia@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/55691
backport of #45313
parent tracker: https://tracker.ceph.com/issues/53244
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh