octopus: osd/PGLog.cc: Trim duplicates by number of entries#46253
Merged
yuriw merged 2 commits intoceph:octopusfrom Jun 1, 2022
Merged
octopus: osd/PGLog.cc: Trim duplicates by number of entries#46253yuriw merged 2 commits intoceph:octopusfrom
yuriw merged 2 commits intoceph:octopusfrom
Conversation
Adding duplicate entries trimming to trim-pg-log opertion, we will use the exist PGLog trim function to find out the set of entries\dup entries that we suppose to trim. to use it we need to build the PGLog from disk. Fixed: https://tracker.ceph.com/issues/53729 Signed-off-by: Nitzan Mordechai <nmordec@redhat.com> (cherry picked from commit 9fb7ec6) Conflicts: src/osd/PGLog.h -- octopus does not have the commit 8777980 which cleans the `std` namespace depedency in headers. src/tools/ceph_objectstore_tool.cc -- octopus lacks the commit 7d73fa6 which puts the buffer's error hierarchy on `system_error`.
PGLog needs to trim duplicates by the number of entries rather than the versions. That way, we prevent unbounded duplicate growth. Fixed: https://tracker.ceph.com/issues/53729 Signed-off-by: Nitzan Mordechai <nmordec@redhat.com> (cherry picked from commit 0d253bc)
NitzanMordhai
approved these changes
May 13, 2022
Member
|
Rados suite results: http://pulpito.front.sepia.ceph.com/?branch=wip-yuri5-testing-2022-05-13-1402-octopus Failures, unrelated: Details: |
14 tasks
14 tasks
yuriw
added a commit
that referenced
this pull request
Jul 11, 2022
octopus: revert of #46253, add tools: ceph-objectstore-tool is able to trim solely pg log dups' entries Reviewed-by: Neha Ojha <nojha@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is NOT a clean backport of #45529. Please review.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows