Skip to content

debian: Fix File not found ... cephfs_top-*.egg-info#45903

Closed
djgalloway wants to merge 1 commit intomasterfrom
wip-cephfstop
Closed

debian: Fix File not found ... cephfs_top-*.egg-info#45903
djgalloway wants to merge 1 commit intomasterfrom
wip-cephfstop

Conversation

@djgalloway
Copy link
Contributor

@djgalloway djgalloway commented Apr 13, 2022

Copying what was done in e6eee05 but for cephfs-top

Jenkins build: https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/62024/console

This should fix master builds.

Signed-off-by: David Galloway dgallowa@redhat.com

@djgalloway djgalloway requested review from tchaikov and vshankar April 13, 2022 21:07
vshankar
vshankar reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tchaikov
tchaikov reviewed Apr 14, 2022
View reviewed changes
debian: Fix File not found ... cephfs_top-*.egg-info
3a9de0d 
Copying what was done in e6eee05 but for cephfs-top

Signed-off-by: David Galloway <dgallowa@redhat.com>
@djgalloway
Copy link
Contributor Author

djgalloway commented Apr 14, 2022

master builds are passing again and I'm not entirely sure why but maybe this change isn't necessary after all.

@tchaikov
Copy link
Contributor

tchaikov commented Apr 15, 2022

weird... i did test my fix before merging it. unlike ceph_argparse.py and ceph_daemon.py, cephfs-top installs itself in the "proper" way. so its installation should be taken care of by debian.

@djgalloway could you point me to the build failure?

@tchaikov
Copy link
Contributor

tchaikov commented Apr 16, 2022 •
edited
Loading

found one

Copying cephfs_top.egg-info to /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11639-g5a2a646b/rpm/el8/BUILDROOT/ceph-17.0.0-11639.g5a2a646b.el8.x86_64/usr/lib/python3.8/site-packages/cephfs_top-0.0.1-py3.8.egg-info
running install_scripts
...
error: File not found: /home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11639-g5a2a646b/rpm/el8/BUILDROOT/ceph-17.0.0-11639.g5a2a646b.el8.x86_64/usr/lib/python3.6/site-packages/cephfs_top-*.egg-info

https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/62075//consoleFull

seems an unexpected find_package(Python3 ...) without an exact python3 version specified as called after the one with version specified and before distutils_install_module(cephfs-top).

should be addressed by #45916

tchaikov
tchaikov requested changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe #45916 is the right fix.

@djgalloway djgalloway closed this Apr 19, 2022
@djgalloway djgalloway deleted the wip-cephfstop branch April 19, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar left review comments

@tchaikov tchaikov tchaikov requested changes

Assignees

No one assigned

Labels

build/ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djgalloway @tchaikov @vshankar