cmake/modules: always use the python3 specified in command line#45916
Merged
djgalloway merged 1 commit intoceph:masterfrom Apr 19, 2022
Merged
cmake/modules: always use the python3 specified in command line#45916djgalloway merged 1 commit intoceph:masterfrom
djgalloway merged 1 commit intoceph:masterfrom
Conversation
if another python3 with higher version is found by find_package(Python3), the cmake's install script would just install the python modules/extensions into that python3's dist-package directory, and the packaging script would fail to find these artifacts when trying to package them. so we need to ensure that the install directories for python modeules/extensions are always "versioned" with WITH_PYTHON3 cmake option. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Contributor
Author
|
this change should address the packaging failure at https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/62075//consoleFull |
Contributor
Author
djgalloway
approved these changes
Apr 19, 2022
Contributor
|
Does this need to get backported now too? |
14 tasks
Contributor
Author
|
@djgalloway yup. to ensure the build is repeatable on building host which happens to have non-offical python version installed. just created |
Contributor
|
Miss you so much ❤️ |
14 tasks
Contributor
|
Could this PR possibly be causing (or does it fix): |
1 similar comment
Contributor
|
Could this PR possibly be causing (or does it fix): |
Contributor
Author
|
this is exact the issue I wanted to fix. But I failed to pass EXACT to
find_package(). Will fix it ASAP.
David Galloway ***@***.***>于2022年4月21日 周四04:56写道：
Could this PR possibly be causing (or does it fix):
-- Performing Test HAS_WARNING_PESSIMIZING_MOVE
-- Performing Test HAS_WARNING_PESSIMIZING_MOVE - Success
CMake Error at cmake/modules/FindCython.cmake:13 (message):
Could not find cython: /usr/bin/python3.8: No module named cython
Call Stack (most recent call first):
src/pybind/CMakeLists.txt:5 (find_package)
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find Cython (missing: CYTHON_VERSION)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
cmake/modules/FindCython.cmake:16 (find_package_handle_standard_args)
src/pybind/CMakeLists.txt:5 (find_package)
-- Configuring incomplete, errors occurred!
See also "/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11737-g10090b63/rpm/el8/BUILD/ceph-17.0.0-11737-g10090b63/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log".
See also "/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/17.0.0-11737-g10090b63/rpm/el8/BUILD/ceph-17.0.0-11737-g10090b63/x86_64-redhat-linux-gnu/CMakeFiles/CMakeError.log".
error: Bad exit status from /var/tmp/rpm-tmp.YBHbYI (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.YBHbYI (%build)
+ rm -fr /tmp/install-deps.2297837
Build step 'Execute shell' marked build as failure
https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/62167/
—
Reply to this email directly, view it on GitHub
<#45916 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAONP27O7LWK6DWOHELQXTVGBVQBANCNFSM5TRT2GBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Regards
Kefu Chai
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if another python3 with higher version is found by
find_package(Python3), the cmake's install script would just
install the python modules/extensions into that python3's
dist-package directory, and the packaging script would fail
to find these artifacts when trying to package them.
so we need to ensure that the install directories for python
modeules/extensions are always "versioned" with WITH_PYTHON3
cmake option.
Signed-off-by: Kefu Chai tchaikov@gmail.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows