OSD: handle the case where we resurrected an old, deleted pg#4539
Merged
athanatos merged 1 commit intoceph:masterfrom May 4, 2015
Merged
OSD: handle the case where we resurrected an old, deleted pg#4539athanatos merged 1 commit intoceph:masterfrom
athanatos merged 1 commit intoceph:masterfrom
Conversation
Prior to giant, we would skip pgs in load_pgs which were not present in the current osdmap. Those pgs would eventually refer to very old osdmaps, which we no longer have causing the assertion failure in 11429 once the osd is finally upgraded to a version which does not skip the pgs. Instead, if we do not have the map for the pg epoch, complain to the osd log and skip the pg. Fixes: 11429 Signed-off-by: Samuel Just <sjust@redhat.com>
Contributor
Author
|
ceph-qa-suite and teuthology branches to follow |
Contributor
Author
|
ceph-qa-suite: ceph/ceph-qa-suite#428 |
athanatos
pushed a commit
that referenced
this pull request
May 4, 2015
OSD: handle the case where we resurrected an old, deleted pg Reviewed-by: Sage Weil <sage@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to giant, we would skip pgs in load_pgs which were not present in
the current osdmap. Those pgs would eventually refer to very old
osdmaps, which we no longer have causing the assertion failure in 11429
once the osd is finally upgraded to a version which does not skip the
pgs. Instead, if we do not have the map for the pg epoch, complain to
the osd log and skip the pg.
Fixes: 11429
Signed-off-by: Samuel Just sjust@redhat.com