Skip to content

pacific: test: fix wrong alarm (HitSetWrite)#45319

Merged
yuriw merged 1 commit intoceph:pacificfrom
ljflores:wip-52078-pacific
Mar 22, 2022
Merged

pacific: test: fix wrong alarm (HitSetWrite)#45319
yuriw merged 1 commit intoceph:pacificfrom
ljflores:wip-52078-pacific

Conversation

@ljflores
Copy link
Member

@ljflores ljflores commented Mar 9, 2022

backport tracker: https://tracker.ceph.com/issues/52078


backport of #42564
parent tracker: https://tracker.ceph.com/issues/45423

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

This is not a serious bug. Please look over the following scenario
in HitSetWrite test:

1. append object, which causes to add the object to the hitset
2. call hit_set_get to get the object accessed recently
3. see the hitset to check that appened object is in the hitset

After step 2, assert occurs because plpg_on_pool_change,
which invokes hit_set_clear, is called
between step 1 and step 2.
So, the object this unit test want to add to the hitset
is not in the hitset sometime.
To avoid this, this commit adds retry logic.

Fixes: https://tracker.ceph.com/issues/45423

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
(cherry picked from commit 9a02069)
@ljflores ljflores added this to the pacific milestone Mar 9, 2022
@github-actions github-actions bot added the tests label Mar 9, 2022
@ljflores ljflores requested a review from myoungwon March 9, 2022 16:13
@ljflores
Copy link
Member Author

ljflores commented Mar 9, 2022

@myoungwon saw that this fix was never backported. See if it's still needed.

@djgalloway
Copy link
Contributor

jenkins test windows

@yuriw yuriw merged commit a122876 into ceph:pacific Mar 22, 2022
@ljflores ljflores deleted the wip-52078-pacific branch March 23, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants