test: fix wrong alarm (HitSetWrite)#42564
Merged
tchaikov merged 1 commit intoceph:masterfrom Aug 6, 2021
Merged
Conversation
This is not a serious bug. Please look over the following scenario in HitSetWrite test: 1. append object, which causes to add the object to the hitset 2. call hit_set_get to get the object accessed recently 3. see the hitset to check that appened object is in the hitset After step 2, assert occurs because plpg_on_pool_change, which invokes hit_set_clear, is called between step 1 and step 2. So, the object this unit test want to add to the hitset is not in the hitset sometime. To avoid this, this commit adds retry logic. Fixes: https://tracker.ceph.com/issues/45423 Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Member
Author
|
@neha-ojha @athanatos @tchaikov Any comment? |
Member
|
jenkins test make check |
Member
|
jenkins test api |
Member
Based on your explanation in the commit message, adding a retry logic makes sense. Are you able to reproduce this issue reliably? |
athanatos
approved these changes
Aug 4, 2021
This was referenced Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a serious bug. Please look over the following scenario
in HitSetWrite test:
After step 2, assert occurs because plpg_on_pool_change,
which invokes hit_set_clear, is called
between step 1 and step 2.
So, the object this unit test want to add to the hitset
is not in the hitset sometime.
To avoid this, this commit adds retry logic.
Fixes: https://tracker.ceph.com/issues/45423
Signed-off-by: Myoungwon Oh myoungwon.oh@samsung.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox