mds: notify clients if the session has already opened#45307
Merged
vshankar merged 3 commits intoceph:masterfrom Apr 25, 2022
Merged
mds: notify clients if the session has already opened#45307vshankar merged 3 commits intoceph:masterfrom
vshankar merged 3 commits intoceph:masterfrom
Conversation
3009978 to
fa18e28
Compare
kotreshhr
reviewed
Mar 14, 2022
kotreshhr
reviewed
Mar 14, 2022
Contributor
Member
Author
vshankar
reviewed
Mar 18, 2022
src/mds/Server.cc
Outdated
| dout(10) << "currently open|opening|stale|killing, dropping this req" << dendl; | ||
| dout(10) << "currently open|opening|stale|killing" << dendl; | ||
| if (m->supported_features.test(CEPHFS_FEATURE_REFRESH_SESSION)) { | ||
| auto reply = make_message<MClientSession>(CEPH_SESSION_ALREADY_OPEN, |
Contributor
There was a problem hiding this comment.
Did you consider sending CEPH_SESSION_OPEN back to the client if the session is already open?
(In client, the case for CEPH_SESSION_ALREADY_OPEN falls-through to CEPH_SESSION_OPEN anyway)
Member
Author
There was a problem hiding this comment.
Yeah, let me try this. Mainly different is updating the seq.
Member
Author
|
Just rebased it to the latest code, nothing changed. |
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Client side never uses this seq. Signed-off-by: Xiubo Li <xiubli@redhat.com>
If the connection was accidently closed due to the socket issue or something else the client will try to open the opened sessions, for now the MDS will just discard the session open request. But the client will keep waiting the reply from the mds forever. We need to tell the clients what has happened instead of discard it directly. And when the client get the session open reply, it can do what needed. Fixes: https://tracker.ceph.com/issues/53911 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Member
Author
|
Just rebased it to the latest code, nothing changed. |
Contributor
vshankar
approved these changes
Apr 25, 2022
yunfeiguan
reviewed
Jul 7, 2022
This was referenced Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the connection was accidently closed due to the socket issue or
something else the client will try to open the opened sessions, for
now the MDS will just discard the session open request.
But the client will keep waiting the reply from the mds forever.
We need to tell the clients what has happened instead of discard it
directly. And when the client get the session open reply, it can
do what needed.
Fixes: https://tracker.ceph.com/issues/53911
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows