mds: kill session state are open when mds do ms_handle_remote_reset#44638
Merged
vshankar merged 1 commit intoceph:masterfrom Feb 9, 2022
Merged
mds: kill session state are open when mds do ms_handle_remote_reset#44638vshankar merged 1 commit intoceph:masterfrom
vshankar merged 1 commit intoceph:masterfrom
Conversation
if the mds decide to reuse the old connection it will do reset_session and should also kill the session which are open state in MDSDaemon::ms_handle_remote_reset to prevent the situation client session is stuck in opening state and never has chance to becaome open. the root cause is client missed the request_open reply but the mds session has become open already. so we should kill the session in mds side and let mds recreate the session when received the connect request from client. Fixes: http://tracker.ceph.com/issues/53911 Signed-off-by: YunfeiGuan <yunfeiguan@xtaotech.com>
Contributor
|
Should the client use a new connection to the MDS after |
Contributor
Member
|
@yunfeiguan Could check this issue again ? I have reverted it in #45307 since it will introduce a new issues. Please let me know if you want me to code this. Thanks. |
Member
I will fix this together with #45307. |
This was referenced Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the mds decide to reuse the old connection it will
do reset_session and should also kill the session
which are open state in MDSDaemon::ms_handle_remote_reset
to prevent the situation client session is stuck in
opening state and never has chance to becaome open.
the root cause is client missed the request_open
reply but the mds session has become open already.
so we should kill the session in mds side and let
mds recreate the session when received the connect
request from client.
Fixes: http://tracker.ceph.com/issues/53911
Signed-off-by: YunfeiGuan yunfeiguan@xtaotech.com