qa/cephfs: upgrade is_mounted() in mount.py by rishabh-d-dave · Pull Request #45036 · ceph/ceph

rishabh-d-dave · 2022-02-15T05:33:15Z

Related PR - PR #46988

Instead of relying on value of a mutable variable, actually check if the
CephFS is mounted on the system. This will prevent bugs due to stale and
incorrect values.

Fixes: https://tracker.ceph.com/issues/54283

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

rishabh-d-dave · 2022-02-15T05:41:26Z

Discussion regarding this patch was initiated here. It's better to backport this PR to prevent bugs. I've created a tracker for the same.

batrick

Otherwise LGTM

qa/tasks/cephfs/mount.py

qa/cephfs: upgrade is_mounted() in mount.py Instead of relying on value of a mutable variable, actually check if the CephFS is mounted on the system. This will prevent bugs due to stale and incorrect values. Fixes: https://tracker.ceph.com/issues/54283 Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2022-04-26T10:41:55Z

jenkins test make check

rishabh-d-dave · 2022-05-05T07:10:26Z

Just a rebase.

lxbsz

LGTM.

rishabh-d-dave · 2022-05-05T08:36:44Z

@vshankar PTAL.

rishabh-d-dave · 2022-05-05T09:37:53Z

jenkins test api

qa/cephfs: upgrade is_mounted() in mount.py Instead of relying on value of a mutable variable, actually check if the CephFS is mounted on the system. This will prevent bugs due to stale and incorrect values. Fixes: https://tracker.ceph.com/issues/54283 Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2022-07-20T12:46:29Z

Need to retest this PR with teuth due to recent changes.

rishabh-d-dave · 2022-07-20T13:00:48Z

jenkins test make check

qa/tasks/cephfs/mount.py

Instead of relying on value of a mutable variable, actually check if the CephFS is mounted on the system. This will prevent bugs due to stale and incorrect values. Fixes: https://tracker.ceph.com/issues/54283 Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2022-07-20T18:23:28Z

jenkins test windows

rishabh-d-dave · 2022-07-20T19:09:18Z

jenkins test windows

rishabh-d-dave · 2022-07-21T02:48:01Z

jenkins test make check

rishabh-d-dave · 2022-07-21T03:04:58Z

jenkins test api

rishabh-d-dave · 2022-07-21T06:41:07Z

Doesn't look like a related failure - https://jenkins.ceph.com/job/ceph-api/41031/

rishabh-d-dave · 2022-07-21T06:41:14Z

jenkins test api

rishabh-d-dave · 2022-07-21T06:50:46Z

@lxbsz @kotreshhr @nmshelke Please review and approve this PR again. This PR now checks output of cat /proc/self/mounts instead of running findmnt. CephFS tests can have a case where a client, expectedly or unexpectedly, has been evicted. Since findmnt hangs in such a case, we are using to an alternate solution which was suggested by Patrick.

See -

https://github.com/ceph/ceph/pull/45036/files#diff-a31fb9fe7c629a895231a8bd8f0f3f5874dc251130c571fb0ac40a6911c554ceR171-R173

https://github.com/ceph/ceph/compare/e2e233e2ad80227b9516808d647fca6794cc9df3..f96031b9202b2169e2d81746d14daa702864857c

lxbsz

LGTM.

kotreshhr

lgtm

qa/cephfs: upgrade is_mounted() in mount.py Instead of relying on value of a mutable variable, actually check if the CephFS is mounted on the system. This will prevent bugs due to stale and incorrect values. Fixes: https://tracker.ceph.com/issues/54283 Signed-off-by: Rishabh Dave <ridave@redhat.com>

rishabh-d-dave · 2022-07-21T10:21:00Z

Now since we are not using findmnt anymore, this PR no more exposes the issue where findmnt would hang because client has been evicted (this issue is reported at tracker ticket https://traker.ceph.com/issues/56476).

The fact that the tests that failed with findmnt patch now run successfully with the new patch confirms this - http://pulpito.front.sepia.ceph.com/rishabh-2022-07-21_09:19:44-fs-wip-rishabh-fs-auth-subcmd-distro-default-smithi/

This PR is on ready for QA run.

cc: @batrick @vshankar

qa/tasks/cephfs/mount.py

nmshelke

LGTM

dparmar18

LGTM

rishabh-d-dave · 2022-08-19T13:09:30Z

https://tracker.ceph.com/projects/cephfs/wiki/Main#2022-Jul-25

github-actions bot added cephfs Ceph File System tests labels Feb 15, 2022

rishabh-d-dave added bug-fix needs-review labels Feb 15, 2022

rishabh-d-dave requested review from a team and vshankar February 15, 2022 05:34

rishabh-d-dave changed the title ~~qa/cephfs: upgrade mount.is_mounted()~~ qa/cephfs: upgrade is_mounted() in mount.py Feb 15, 2022

rishabh-d-dave force-pushed the qa-fix-is_mounted branch from 0dd2aa9 to 7cbb2fe Compare February 15, 2022 05:38

rishabh-d-dave force-pushed the qa-fix-is_mounted branch from 7cbb2fe to 0e95374 Compare February 15, 2022 13:38

batrick requested changes Feb 15, 2022

View reviewed changes

qa/tasks/cephfs/mount.py Outdated Show resolved Hide resolved

nmshelke reviewed Mar 13, 2022

View reviewed changes

qa/tasks/cephfs/mount.py Outdated Show resolved Hide resolved

rishabh-d-dave force-pushed the qa-fix-is_mounted branch from 0e95374 to d936d3c Compare April 18, 2022 05:08

rishabh-d-dave mentioned this pull request Apr 19, 2022

qa/cephfs: upgrade xfstests_dev.py for FUSE mounts #44240

Merged

14 tasks

rishabh-d-dave force-pushed the qa-fix-is_mounted branch from d936d3c to a2dfd11 Compare May 2, 2022 10:56

rishabh-d-dave requested review from batrick, lxbsz and nmshelke May 2, 2022 11:01

rishabh-d-dave force-pushed the qa-fix-is_mounted branch from a2dfd11 to 6d8e508 Compare May 5, 2022 07:10

lxbsz approved these changes May 5, 2022

View reviewed changes

rishabh-d-dave added wip-rishabh-testing Rishabh's testing label needs-qa and removed needs-review labels May 10, 2022

vshankar added the wip-vshankar-testing label May 23, 2022

batrick reviewed Jul 20, 2022

View reviewed changes

qa/tasks/cephfs/mount.py Outdated Show resolved Hide resolved

rishabh-d-dave force-pushed the qa-fix-is_mounted branch from e2e233e to f96031b Compare July 20, 2022 17:06

rishabh-d-dave requested a review from batrick July 20, 2022 18:48

rishabh-d-dave requested review from kotreshhr, lxbsz and nmshelke July 21, 2022 06:45

lxbsz approved these changes Jul 21, 2022

View reviewed changes

kotreshhr approved these changes Jul 21, 2022

View reviewed changes

rishabh-d-dave removed the DNM label Jul 21, 2022

ajarr approved these changes Jul 21, 2022

View reviewed changes

dparmar18 reviewed Jul 21, 2022

View reviewed changes

qa/tasks/cephfs/mount.py Show resolved Hide resolved

nmshelke approved these changes Jul 21, 2022

View reviewed changes

dparmar18 approved these changes Jul 22, 2022

View reviewed changes

rishabh-d-dave added wip-rishabh-testing Rishabh's testing label and removed needs-qa labels Jul 22, 2022

batrick approved these changes Jul 22, 2022

View reviewed changes

Conversation

rishabh-d-dave commented Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

rishabh-d-dave commented Feb 15, 2022

Uh oh!

batrick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rishabh-d-dave commented Apr 26, 2022

Uh oh!

rishabh-d-dave commented May 5, 2022

Uh oh!

lxbsz left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented May 5, 2022

Uh oh!

rishabh-d-dave commented May 5, 2022

Uh oh!

rishabh-d-dave commented Jul 20, 2022

Uh oh!

rishabh-d-dave commented Jul 20, 2022

Uh oh!

Uh oh!

rishabh-d-dave commented Jul 20, 2022

Uh oh!

rishabh-d-dave commented Jul 20, 2022

Uh oh!

rishabh-d-dave commented Jul 21, 2022

Uh oh!

rishabh-d-dave commented Jul 21, 2022

Uh oh!

rishabh-d-dave commented Jul 21, 2022

Uh oh!

rishabh-d-dave commented Jul 21, 2022

Uh oh!

rishabh-d-dave commented Jul 21, 2022

Uh oh!

lxbsz left a comment

Choose a reason for hiding this comment

Uh oh!

kotreshhr left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nmshelke left a comment

Choose a reason for hiding this comment

Uh oh!

dparmar18 left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Aug 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rishabh-d-dave commented Feb 15, 2022 •

edited

Loading

rishabh-d-dave commented Jul 21, 2022 •

edited

Loading