mgr/rook: implementing OSD removal in the rook orchestrator#42858
Merged
josephsawaya merged 5 commits intoceph:masterfrom Aug 26, 2021
Merged
mgr/rook: implementing OSD removal in the rook orchestrator#42858josephsawaya merged 5 commits intoceph:masterfrom
josephsawaya merged 5 commits intoceph:masterfrom
Conversation
added 3 commits
August 19, 2021 16:01
This commit adds the AppsV1Api to the Rook Orchestrator module to scale and delete deployments. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
This commit implements OSD removal for the Rook Orchestrator by implmenting the remove_osds methods in RookOrchestrator and RookCluster. This commit creates the DefaultRemover class that handles making k8s API calls, patching the cluster CR and making mon_command calls. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
This commit fixes a bug in the OSD removal process that removes all prepare jobs for OSDs in the same device set as the one that is being removed. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
jmolmo
reviewed
Aug 24, 2021
jmolmo
reviewed
Aug 24, 2021
jmolmo
reviewed
Aug 24, 2021
jmolmo
requested changes
Aug 24, 2021
Member
jmolmo
left a comment
There was a problem hiding this comment.
looks good... just a couple of minor nits ...
josephsawaya
commented
Aug 24, 2021
| log.error(f"error setting down flags on OSDs, {err}") | ||
| raise RuntimeError(err) | ||
|
|
||
| def scale_deployments(self) -> None: |
jmolmo
requested changes
Aug 25, 2021
added 2 commits
August 25, 2021 09:53
This commit adds a label_selector to the fetching of the osd pods and osd prepare jobs in the DefaultRemover. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
This commit adds better error handling to the remove method in the DefaultRemover by hiding stack traces from the user and displaying meaningful error messages. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
9c1393e to
674b2f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements OSD removal using
ceph orch osd rmin the rook orchestrator.Adds the AppsV1 k8s python api to the rook orchestrator to manipulate deployment resources.
Implement remove_osds method in RookOrchestrator class.
Creates the DefaultRemover class that handles:
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox