mgr/nfs: fix rgw exports; update docs#42406
Merged
liewegas merged 15 commits intoceph:masterfrom Jul 27, 2021
Merged
Conversation
asannes
reviewed
Jul 20, 2021
Contributor
|
Turns out this was a bigger issue: #42433 |
Contributor
Contributor
|
jenkins test make check |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
Comment on lines
+211
to
+220
| owner = j.get('owner', '') | ||
| rgwfsal.user_id = owner | ||
| ret, out, err = self._exec([ | ||
| 'radosgw-admin', 'user', 'info', '--uid', owner | ||
| ]) | ||
| if ret: | ||
| raise NFSException( | ||
| f'Failed to fetch key for bucket {export.path} owner {owner}' | ||
| ) | ||
| j = json.loads(out) |
Contributor
There was a problem hiding this comment.
Add note about creating user manually
Member
Author
There was a problem hiding this comment.
@yehudasa is there a case where the bucket owner user wouldn't exist?
varshar16
reviewed
Jul 22, 2021
varshar16
reviewed
Jul 22, 2021
Signed-off-by: Sage Weil <sage@newdream.net>
- clean up language - move config hierarchy to the bottom (this is an implementation detail that is only useful if managing ganesha externally) Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
…ainer image We were using CEPH_TYPES + GATEWAY_TYPES, but that isn't really accurate. Signed-off-by: Sage Weil <sage@newdream.net>
The bucket owner can always read/write to the bucket, so use those creds for the export. This is less complicated than setting up a dedicated user anyway. Signed-off-by: Sage Weil <sage@newdream.net>
The cephfs variant already has it. Signed-off-by: Sage Weil <sage@newdream.net>
This doesn't normally happen, but did before the daemon inventory breakage (see previous patches) was fixed. Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
Member
Author
varshar16
reviewed
Jul 27, 2021
varshar16
reviewed
Jul 27, 2021
varshar16
approved these changes
Jul 27, 2021
Contributor
varshar16
left a comment
There was a problem hiding this comment.
The doc comments needs to be addressed. Otherwise looks good.
This documentation is incomplete because this mode of operation is not tested/validated. Signed-off-by: Sage Weil <sage@newdream.net>
Link to the cephadm docs on modifying the service directly. Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Sage Weil <sage@newdream.net>
This argument is not used. The rgw exports currently only work on the default realm. Signed-off-by: Sage Weil <sage@newdream.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also some new tests
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox