mgr/cephadm: Fix haproxy not being recognized as a proper daemon#42433
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Jul 22, 2021
Merged
Conversation
ab753ce to
3cdbf86
Compare
3 tasks
asannes
reviewed
Jul 21, 2021
|
|
||
| if not daemons: | ||
| raise OrchestratorError( | ||
| f'Failed to generate keepalived.conf: Do daemons deployed for {spec.service_name()}') |
adk3798
approved these changes
Jul 21, 2021
Contributor
adk3798
left a comment
There was a problem hiding this comment.
LGTM minus the typo already pointed out
Contributor
|
jenkins test make check |
Turns out daemon types != service types:
cephadm [WRN] Found unknown service type haproxy on host smithi019
cephadm [WRN] Found unknown service type keepalived on host smithi019
leading to `self.mgr.cache.get_daemons_by_service(spec.service_name())`
not returning any daemons.
Fixes: https://tracker.ceph.com/issues/51311
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
3cdbf86 to
a8f1cf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out daemon types != service types:
leading to
self.mgr.cache.get_daemons_by_service(spec.service_name())not returning any daemons.
Fixes: https://tracker.ceph.com/issues/51311
Signed-off-by: Sebastian Wagner sewagner@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox