mgr/cephadm: ingress: fix typo in spec.virtual_interface_networks reference#42389
Merged
tchaikov merged 1 commit intoceph:masterfrom Jul 28, 2021
Merged
mgr/cephadm: ingress: fix typo in spec.virtual_interface_networks reference#42389tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
…erence When using virtual_inteface_networks to identify the interface to have the virtual ip on, it referenced spec.networks instead of spec.virtual_interface_networks. Fixes: https://tracker.ceph.com/issues/51721 Signed-off-by: Asbjørn Sannes <asbjorn.sannes@interhost.no>
Contributor
|
This was referenced Jul 20, 2021
Contributor
|
even though the traceback seems unrelated to this particular PR (see https://tracker.ceph.com/issues/51713#note-1 ). we need to fix the Traceback nevertheless in order to get this merged |
Member
|
… On Tue, Jul 20, 2021 at 9:15 AM Sebastian Wagner ***@***.***> wrote:
even though the traceback seems unrelated to this particular PR (see https://tracker.ceph.com/issues/51713#note-1 ). we need to fix the Traceback nevertheless in order to get this merged
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Contributor
|
i assume that this change should be merged along with #42406 . so leave it unmerged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using virtual_inteface_networks to identify the interface to have the
virtual ip on, it referenced spec.networks instead of
spec.virtual_interface_networks.
Fixes: https://tracker.ceph.com/issues/51721
Signed-off-by: Asbjørn Sannes asbjorn.sannes@interhost.no