mgr/dashboard,cephadm: automate setup of RGW credentials for dashboard by liewegas · Pull Request #42252 · ceph/ceph

liewegas · 2021-07-08T20:10:17Z

New 'ceph dashboard connect-rgw' command to set up RGW credentials
Trigger credential check when rgw service created or destroyed. Note that what we really want is a credential check any time an RGW realm is created or destroyed, but we don't have that visibility. We could supplement by just calling the current check every 24h or something, though. And eventually if/when we have a mgr/rgw module that pulls some of this rgw realm management into the mgr, then we can trigger it at the right time.

@alfonsomthd UPDATE:

Dashboard > Object Gateway: if empty credentials are detected, we trigger the credentials configuration.

Fixes: https://tracker.ceph.com/issues/44605

Related PR: #41590

TODO

we should trigger when the dashboard module is first enabled? or perhaps even when the dashboard loads (on every mgr startup)?
update docs

github-actions · 2021-07-08T20:10:39Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

src/pybind/mgr/dashboard/services/rgw_client.py

alfonsomthd · 2021-08-06T14:08:30Z

jenkins test dashboard

liewegas · 2021-08-09T14:38:39Z

retest this please

Signed-off-by: Sage Weil <sage@newdream.net>

…d/destroyed We don't always know when a realm is created/destroyed, but we can use service config and purge to cover most such cases. Signed-off-by: Sage Weil <sage@newdream.net>

- Align Dashboard with cephadm: configure credentials using the same logic. - Fix: create a 'dashboard' user per realm (before: only on 1st realm). - Lint fixes, test coverage, method renaming to better reflect behavior and method visibility. Fixes: https://tracker.ceph.com/issues/44605 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

- Rename the dashboard command to better reflect its behavior. - Rename '_radosgw_admin' method to 'send_rgwadmin_command' for consistency with 'send_mon_command' and move it to the mgr_module.py . - Cleanup: remove unneeded rgw settings. - Better error handling and test coverage. Fixes: https://tracker.ceph.com/issues/44605 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

…ce spec. Align rgw service id pattern with cephadm: ceph#39877 - Update rgw pattern to allow service id for non-multisite config. - Extract realm and zone from service id (when detected) and add them to the service spec. Fixes: https://tracker.ceph.com/issues/44605 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

Fixes: https://tracker.ceph.com/issues/44605 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

alfonsomthd · 2021-08-11T07:04:48Z

jenkins test make check arm64

jmolmo

LGTM

alfonsomthd · 2021-08-11T14:54:40Z

jenkins test make check arm64

Since [1] multiple ceph dashboard commands have been removed and this is breaking the current ceph-ansible dashboard with RGW automation. This removes the following dashboard rgw commands: - ceph dashboard set-rgw-api-access-key - ceph dashboard set-rgw-api-secret-key - ceph dashboard set-rgw-api-host - ceph dashboard set-rgw-api-port - ceph dashboard set-rgw-api-scheme Which are replaced by `ceph dashboard set-rgw-credentials` The RGW user creation task is also removed. Finally moving the delegate_to statement from the rgw tasks at the block level. [1] ceph/ceph#42252 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

sebastian-philipp · 2021-08-17T15:48:23Z

TASK [ceph-dashboard : set the rgw user] ***************************************
task path: /home/jenkins-build/build/workspace/ceph-ansible-prs-centos-container-update/roles/ceph-dashboard/tasks/configure_dashboard.yml:274
Tuesday 17 August 2021  14:37:08 +0000 (0:00:00.100)       0:22:14.819 ******** 
fatal: [mgr0 -> mon0]: FAILED! => changed=false 
  cmd:
  - podman
  - exec
  - ceph-mon-mon0
  - ceph
  - --cluster
  - ceph
  - dashboard
  - set-rgw-api-user-id
  - ceph-dashboard
  delta: '0:00:00.537218'
  end: '2021-08-17 14:37:08.831031'
  msg: non-zero return code
  rc: 22
  start: '2021-08-17 14:37:08.293813'
  stderr: |-
    no valid command found; 10 closest matches:
    dashboard set-jwt-token-ttl <seconds:int>
    dashboard get-jwt-token-ttl
    dashboard create-self-signed-cert
    dashboard grafana dashboards update
    dashboard get-account-lockout-attempts
    dashboard set-account-lockout-attempts <value>
    dashboard reset-account-lockout-attempts
    dashboard get-alertmanager-api-host
    dashboard set-alertmanager-api-host <value>
    dashboard reset-alertmanager-api-host
    Error EINVAL: invalid command
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

Since [1] multiple ceph dashboard commands have been removed and this is breaking the current ceph-ansible dashboard with RGW automation. This removes the following dashboard rgw commands: - ceph dashboard set-rgw-api-access-key - ceph dashboard set-rgw-api-secret-key - ceph dashboard set-rgw-api-host - ceph dashboard set-rgw-api-port - ceph dashboard set-rgw-api-scheme Which are replaced by `ceph dashboard set-rgw-credentials` The RGW user creation task is also removed. Finally moving the delegate_to statement from the rgw tasks at the block level. [1] ceph/ceph#42252 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

Since [1] multiple ceph dashboard commands have been removed and this is breaking the current ceph-ansible dashboard with RGW automation. This removes the following dashboard rgw commands: - ceph dashboard set-rgw-api-access-key - ceph dashboard set-rgw-api-secret-key - ceph dashboard set-rgw-api-host - ceph dashboard set-rgw-api-port - ceph dashboard set-rgw-api-scheme Which are replaced by `ceph dashboard set-rgw-credentials` The RGW user creation task is also removed. Finally moving the delegate_to statement from the rgw tasks at the block level. [1] ceph/ceph#42252 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> (cherry picked from commit 2ee2194)

Since [1] multiple ceph dashboard commands have been removed and this is breaking the current ceph-ansible dashboard with RGW automation. This removes the following dashboard rgw commands: - ceph dashboard set-rgw-api-access-key - ceph dashboard set-rgw-api-secret-key - ceph dashboard set-rgw-api-host - ceph dashboard set-rgw-api-port - ceph dashboard set-rgw-api-scheme Which are replaced by `ceph dashboard set-rgw-credentials` The RGW user creation task is also removed. Finally moving the delegate_to statement from the rgw tasks at the block level. [1] ceph/ceph#42252 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>

liewegas requested review from a team as code owners July 8, 2021 20:10

liewegas requested review from Waadkh7, aaryanporwal and cypherean and removed request for a team July 8, 2021 20:10

github-actions bot added cephadm dashboard pybind labels Jul 8, 2021

github-actions bot added the needs-rebase label Jul 8, 2021

liewegas mentioned this pull request Jul 8, 2021

mgr/cephadm: automatically configure dashboard <-> RGW connection #41590

Closed

2 tasks

liewegas force-pushed the dashboard-rgw branch from afe3c84 to 6a6a3ce Compare July 8, 2021 20:25

github-actions bot added documentation mgr and removed needs-rebase labels Jul 8, 2021

alfonsomthd requested review from aaSharma14, alfonsomthd, avanthakkar, epuertat and nizamial09 July 9, 2021 06:56

alfonsomthd reviewed Jul 9, 2021

View reviewed changes

src/pybind/mgr/dashboard/services/rgw_client.py Outdated Show resolved Hide resolved

alfonsomthd requested a review from jmolmo July 9, 2021 07:49

liewegas force-pushed the dashboard-rgw branch 2 times, most recently from 5e34821 to 82d7d3a Compare July 13, 2021 16:53

epuertat added the needs-review label Jul 14, 2021

alfonsomthd force-pushed the dashboard-rgw branch 2 times, most recently from 76e92ef to 5fa7d20 Compare July 28, 2021 14:51

liewegas requested a review from a team July 28, 2021 14:51

github-actions bot added the tests label Jul 28, 2021

liewegas and others added 7 commits August 10, 2021 14:06

doc/mgr/dashboard: simplify dashboard+rgw config docs

599116a

Signed-off-by: Sage Weil <sage@newdream.net>

mgr/dashboard: add 'dashboard connect-rgw' command

478c53b

Signed-off-by: Sage Weil <sage@newdream.net>

mgr/cephadm: re-check dashboard <-> rgw creds when rgw daemons create…

91e185d

…d/destroyed We don't always know when a realm is created/destroyed, but we can use service config and purge to cover most such cases. Signed-off-by: Sage Weil <sage@newdream.net>

mgr/dashboard: run-frontend-e2e-tests.sh: remove unneeded rgw setting

8e482f3

Fixes: https://tracker.ceph.com/issues/44605 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

alfonsomthd force-pushed the dashboard-rgw branch 2 times, most recently from 84e9930 to 265d79f Compare August 10, 2021 13:52

mgr/dashboard: set rgw credentials: fix api tests

a682b9d

Fixes: https://tracker.ceph.com/issues/44605 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

alfonsomthd force-pushed the dashboard-rgw branch from 265d79f to a682b9d Compare August 11, 2021 07:01

jmolmo approved these changes Aug 11, 2021

View reviewed changes

alfonsomthd self-requested a review August 11, 2021 10:50

liewegas merged commit 6f8bdfb into ceph:master Aug 11, 2021

liewegas deleted the dashboard-rgw branch August 11, 2021 15:28

dsavineau mentioned this pull request Aug 17, 2021

ceph-dashboard: fix object gateway integration ceph/ceph-ansible#6833

Merged

sebastian-philipp mentioned this pull request Sep 2, 2021

pacific: cephadm: September batch 1 #43029

Merged

alfonsomthd mentioned this pull request Sep 29, 2021

pacific: mgr/dashboard,cephadm: automate setup of RGW credentials for dashboard #43342

Closed

galexrt mentioned this pull request Apr 16, 2023

Object Storage page does not load in the Ceph dashboard by default rook/rook#9660

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard,cephadm: automate setup of RGW credentials for dashboard#42252

mgr/dashboard,cephadm: automate setup of RGW credentials for dashboard#42252
liewegas merged 8 commits intoceph:masterfrom
liewegas:dashboard-rgw

liewegas commented Jul 8, 2021 •

edited by alfonsomthd

Loading

Uh oh!

github-actions bot commented Jul 8, 2021

Uh oh!

Uh oh!

alfonsomthd commented Aug 6, 2021

Uh oh!

liewegas commented Aug 9, 2021

Uh oh!

alfonsomthd commented Aug 11, 2021

Uh oh!

jmolmo left a comment

Uh oh!

alfonsomthd commented Aug 11, 2021

Uh oh!

sebastian-philipp commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

liewegas commented Jul 8, 2021 • edited by alfonsomthd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 8, 2021

Uh oh!

Uh oh!

alfonsomthd commented Aug 6, 2021

Uh oh!

liewegas commented Aug 9, 2021

Uh oh!

alfonsomthd commented Aug 11, 2021

Uh oh!

jmolmo left a comment

Choose a reason for hiding this comment

Uh oh!

alfonsomthd commented Aug 11, 2021

Uh oh!

sebastian-philipp commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

liewegas commented Jul 8, 2021 •

edited by alfonsomthd

Loading