osd: erasure-code-profile incremental rm before set#4066
Conversation
It is possible for an incremental change to have both a rm and a set for a given erasure code profile. It only happens when a rm is followed by a set. When a set is followed by a rm, the rm will remove the pending set in the incremental change. The logic is the same for pool create and pool delete. We must apply the incremental erasure-code-profile removal before the creation otherwise rm and set in the same proposal will ignore the set. This fix is minimal. A better change would be that erasure-code-profile set checks if there is a pending removal and wait_for_finished_proposal before creating. http://tracker.ceph.com/issues/11144 Fixes: #11144 Signed-off-by: Loic Dachary <ldachary@redhat.com>
|
SUCCESS: the output of run-make-check.sh on centos-7 for aa3f948 is http://paste2.org/7mmjOjzK |
Sent from
Author
|
I guess it needs review before it needs qa ;-) |
Member
|
This looks right to me, Reviewed-by: |
athanatos
pushed a commit
that referenced
this pull request
Mar 19, 2015
osd: erasure-code-profile incremental rm before set Reviewed-by: Sage Weil <sage@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for an incremental change to have both a rm and a set for
a given erasure code profile. It only happens when a rm is followed by a
set. When a set is followed by a rm, the rm will remove the pending set
in the incremental change.
The logic is the same for pool create and pool delete.
We must apply the incremental erasure-code-profile removal before the
creation otherwise rm and set in the same proposal will ignore the set.
This fix is minimal. A better change would be that erasure-code-profile
set checks if there is a pending removal and wait_for_finished_proposal
before creating.
http://tracker.ceph.com/issues/11144 Fixes: #11144
Signed-off-by: Loic Dachary ldachary@redhat.com