cephadm: specify addr on bootstrap's host add#40463
Merged
liewegas merged 1 commit intoceph:masterfrom Apr 1, 2021
Merged
Conversation
Signed-off-by: Joao Eduardo Luis <joao@suse.com>
mgfritch
approved these changes
Mar 31, 2021
| cli(['orch', 'host', 'add', host]) | ||
| args = ['orch', 'host', 'add', host] | ||
| if ctx.mon_ip: | ||
| args.append(ctx.mon_ip) |
Contributor
There was a problem hiding this comment.
Suggested change
| args.append(ctx.mon_ip) | |
| args.extend(['--addr', ctx.mon_ip]) |
(nit) avoid confusion with the label arg
sebastian-philipp
approved these changes
Apr 1, 2021
Contributor
sebastian-philipp
left a comment
There was a problem hiding this comment.
to some degree, this is incomplete, as cephadm bootstrap also has a --mon-addrv argument. I'm not sure we should try to parse the addrv here.
mgfritch
added a commit
to mgfritch/aquarium
that referenced
this pull request
May 25, 2021
- Ceph Pacific v16.2.4 + latest backports - includes upstream backport of: - ceph/ceph#40411 - ceph/ceph#40555 - ceph/ceph#40463 Signed-off-by: Michael Fritch <mfritch@suse.com>
mgfritch
added a commit
to mgfritch/aquarium
that referenced
this pull request
May 25, 2021
- Ceph Pacific v16.2.4 + latest backports - includes upstream backport of: - ceph/ceph#40411 - ceph/ceph#40555 - ceph/ceph#40463 Resolves: aquarist-labs#389 Signed-off-by: Michael Fritch <mfritch@suse.com>
mgfritch
added a commit
to mgfritch/aquarium
that referenced
this pull request
May 25, 2021
- Ceph Pacific v16.2.4 + latest backports - includes upstream backport of: - ceph/ceph#40411 - ceph/ceph#40555 - ceph/ceph#40463 Resolves: aquarist-labs#389 Signed-off-by: Michael Fritch <mfritch@suse.com>
3 tasks
mgfritch
added a commit
to mgfritch/aquarium
that referenced
this pull request
May 25, 2021
- Ceph Pacific v16.2.4 + latest backports - includes upstream backport of: - ceph/ceph#40555 - ceph/ceph#40463 Resolves: aquarist-labs#389 Signed-off-by: Michael Fritch <mfritch@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we may end up with an
addressthat may or may not resolve, depending on how resolvable the hostname, by itself, really is. Or, worse, in a Vagrant deployment this might even resolve to127.0.0.1🤷Signed-off-by: Joao Eduardo Luis <joao@suse.com>