octopus: qa/tasks/mgr/test_progress.py: remove calling of _osd_in_out_completed_events_count()#40225
Merged
jdurgin merged 1 commit intoceph:octopusfrom Mar 24, 2021
Conversation
ab6e76a to
e93291a
Compare
…unt() delete the part where _osd_in_out_completed_events_count() was called in test_osd_cannot_recover() and revert to initial state of the function since we don't need to use this function in octopus. Also delete a duplicate of _osd_in_out_events_count(). This must be added by mistake in ceph#39289 as well. No need to fix for the backport in Nautilus: ceph#38173 since the bugs are occured by adding additional code to the cherry-pick specifically for Octopus. fixes: https://tracker.ceph.com/issues/49891 Signed-off-by: Kamoltat <ksirivad@redhat.com>
e93291a to
b81919d
Compare
Member
Author
|
@neha-ojha |
Member
Author
|
This test consists of commit from this PR + df41ea7 from #39360 Ran 9 Tests: |
jdurgin
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete the part where _osd_in_out_completed_events_count()
was called in test_osd_cannot_recover() and revert to initial
state of the function since we don't need to use this function
in octopus. Also delete a duplicate of _osd_in_out_events_count().
This must be added by mistake in #39289 as well.
No need to fix for the backport in Nautilus: #38173
since the bugs are occured by adding additional code to
the cherry-pick specifically for Octopus.
fixes: https://tracker.ceph.com/issues/49891
Signed-off-by: Kamoltat ksirivad@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox