mgr/cephadm: force flag for ok-to-stop and ok-to-stop for monitoring stack#38854
mgr/cephadm: force flag for ok-to-stop and ok-to-stop for monitoring stack#38854sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
jmolmo
left a comment
There was a problem hiding this comment.
For me is ok once solved the "serialization" problem pointed by Sebastian
54de832 to
6b5b937
Compare
tchaikov
left a comment
There was a problem hiding this comment.
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes
6b5b937 to
2624acc
Compare
sebastian-philipp
left a comment
There was a problem hiding this comment.
That's much better! Do you think it's easy to reduce the amount of copy&paste?
2624acc to
7dc91be
Compare
|
Just adjusted this pretty heavily to add a force flag to ok-to-stop rather than just adding notice messages for monitoring daemons. Things to note:
|
7dc91be to
35da57d
Compare
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
|
As a general rule of thumb: Please don't use The difference is: def my_func(param: Optionl[bool]): ...declares a variable as nullable. If you use def my_func(param: bool = False): ...declares cc @ceph/orchestrators |
35da57d to
6b68397
Compare
541742d to
d972bf4
Compare
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
7f02456 to
477abac
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
…stack Daemons that could cause data loss when stopped will always block. Daemons that will only cause loss in availability should block but have a workaround in the form of a force flag if the user is okay with the service being down. Also implements ok-to-stop for monitoring stack daemons that uses this system of blocking on availability loss unless force flag is provided Signed-off-by: Adam King <adking@redhat.com> Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
477abac to
aeeffb0
Compare
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com> (cherry picked from commit 96dcb15)
depends on ceph#38854 Signed-off-by: Daniel-Pivonka <dpivonka@redhat.com>
Daemons that could cause data loss when stopped will always block.
Daemons that will only cause loss in availability should block but have
a workaround in the form of a force flag if the user is okay with the service
being down.
Also implements ok-to-stop for monitoring stack daemons that uses this system
of blocking on availability loss unless force flag is provided
Signed-off-by: Adam King adking@redhat.com
Signed-off-by: Daniel-Pivonka dpivonka@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox