mgr/progress: Global Recovery Event in ceph -s#37327
Merged
tchaikov merged 1 commit intoceph:masterfrom Oct 31, 2020
Merged
Conversation
3 tasks
Member
Author
|
This is a new PR continuing from #29467 |
jdurgin
approved these changes
Sep 25, 2020
Member
jdurgin
left a comment
There was a problem hiding this comment.
This looks good! I think we'll want to follow up with further PRs to improve the efficiency here. For large clusters, looking through all the pg states for this event (and others) by serializing to json with every update is pretty expensive.
The PGMap keeps track of num_pg_by_state internally, so if we expose python accessors to that we don't need to iterate over all pgs to get the number of active+clean pgs.
0e808da to
341ab1e
Compare
tchaikov
previously requested changes
Oct 4, 2020
tchaikov
reviewed
Oct 5, 2020
Contributor
|
@kamoltat looks great! could you squash these changes into a single commit? |
bd36140 to
3e8b69d
Compare
Member
Author
Done! |
tchaikov
previously requested changes
Oct 15, 2020
Contributor
tchaikov
left a comment
There was a problem hiding this comment.
2020-10-15T09:06:17.364 INFO:tasks.cephfs_test_runner:test_osd_cannot_recover (tasks.mgr.test_progress.TestProgress) ... FAIL
2020-10-15T09:06:17.365 INFO:tasks.cephfs_test_runner:
2020-10-15T09:06:17.365 INFO:tasks.cephfs_test_runner:======================================================================
2020-10-15T09:06:17.366 INFO:tasks.cephfs_test_runner:FAIL: test_osd_cannot_recover (tasks.mgr.test_progress.TestProgress)
2020-10-15T09:06:17.366 INFO:tasks.cephfs_test_runner:----------------------------------------------------------------------
2020-10-15T09:06:17.366 INFO:tasks.cephfs_test_runner:Traceback (most recent call last):
2020-10-15T09:06:17.366 INFO:tasks.cephfs_test_runner: File "/home/teuthworker/src/git.ceph.com_ceph-c_wip-kefu-testing-2020-10-14-1541/qa/tasks/mgr/test_pro
gress.py", line 264, in test_osd_cannot_recover
2020-10-15T09:06:17.366 INFO:tasks.cephfs_test_runner: self.assertEqual(len(self._all_events()), osd_count - pool_size)
2020-10-15T09:06:17.367 INFO:tasks.cephfs_test_runner:AssertionError: 2 != 1
Member
Author
@tchaikov Thanks, just updated the test suite |
d8d079b to
f2d50cd
Compare
Member
Author
|
jenkins retest this please |
f2d50cd to
908fb3a
Compare
Contributor
|
@kamoltat no need to run 400+ tests for exercising this change. would suffice. |
c5d51f3 to
1c61434
Compare
1c61434 to
7275611
Compare
Member
Author
|
https://pulpito.ceph.com/ksirivad-2020-10-22_10:35:40-rados:mgr-wip-mgr-progress-global-event-distro-basic-smithi/ |
tchaikov
reviewed
Oct 22, 2020
7275611 to
0118ef5
Compare
Member
Author
|
jenkins retest this please |
0118ef5 to
7396ce2
Compare
Modified the progress module and BaseMgrModule to support Global Recovert Event. Adding more arguments to update_progress_event, ceph_update_progress_event. To only show global recovery event progress with `ceph -s`. All sub events have been move to `ceph progress` Signed-off-by: Kamoltat <ksirivad@redhat.com>
7396ce2 to
2af2afa
Compare
Contributor
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only show Global Progress event in ceph -s
Right now if you want to see all the sub events
You have to do ceph progress.
Signed-off-by: Kamoltat (Junior) Sirivadhna ksirivad@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox