Skip to content

mgr/progress: Global Recovery Event in ceph -s#29467

Closed
kamoltat wants to merge 1 commit intoceph:masterfrom
kamoltat:wip-mgr-progress-global-recovery-event
Closed

mgr/progress: Global Recovery Event in ceph -s#29467
kamoltat wants to merge 1 commit intoceph:masterfrom
kamoltat:wip-mgr-progress-global-recovery-event

Conversation

@kamoltat
Copy link
Member

@kamoltat kamoltat commented Aug 2, 2019 •
edited
Loading

Only show Global Progress event in ceph -s
Right now if you want to see all the sub events
You have to do ceph progress.

Todo: add the command ceph progress detail and json version
update qa test case for test_progress.py

Signed-off-by: Kamoltat (Junior) Sirivadhna ksirivad@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test docs
  • jenkins render docs

@neha-ojha neha-ojha added the mgr label Aug 2, 2019
@kamoltat kamoltat force-pushed the wip-mgr-progress-global-recovery-event branch from a146a41 to 08490cd Compare August 6, 2019 13:50
jdurgin
jdurgin requested changes Aug 9, 2019
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++ pieces all look good!

@kamoltat kamoltat force-pushed the wip-mgr-progress-global-recovery-event branch from c59a6c2 to 8bc816c Compare August 12, 2019 19:06
jdurgin
jdurgin approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! can you squash it down to one commit?

@kamoltat
mgr/progress: Global Recovery Event in ceph -s
cee1b11 
Shows global recovery event progress as well
as other events that is allowed to be shown in
ceph -s.

ceph progress --> show all events that add_to_global_s == True

ceph progress details --> show all events regardless

ceph progress json --> json version of ceph progress

ceph progress details json --> json version of ceph progress details

Lastly, made changes to the test_progress.py file in teutology
so that it also accounts for global recovery event

Signed-off-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-mgr-progress-global-recovery-event branch from 8bc816c to cee1b11 Compare August 14, 2019 15:27
@stale
Copy link

stale bot commented Oct 13, 2019

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 13, 2019
@stale stale bot removed the stale label Oct 30, 2019
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Oct 30, 2019

@jdurgin I guess this PR is abandoned?

@stale
Copy link

stale bot commented Dec 29, 2019

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Dec 29, 2019
@liewegas
Copy link
Member

liewegas commented Jan 21, 2020

@jdurgin want to adopt this?

@stale stale bot removed the stale label Jan 21, 2020
@jdurgin
Copy link
Member

jdurgin commented Jan 21, 2020

@liewegas it's on my list

@liewegas liewegas removed the needs-qa label Jan 23, 2020
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Feb 10, 2020

Note that qa/tasks/mgr/test_progress.py was moved to src/pybind/mgr/progress

@stale
Copy link

stale bot commented Apr 11, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Apr 11, 2020
@jdurgin jdurgin removed the stale label May 5, 2020
@stale
Copy link

stale bot commented Jul 4, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jul 4, 2020
@jdurgin jdurgin removed the stale label Aug 6, 2020
@kamoltat
Copy link
Member Author

kamoltat commented Sep 23, 2020

Closing this PR and Move to #37327

@kamoltat kamoltat closed this Sep 23, 2020
@kamoltat kamoltat mentioned this pull request Sep 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdurgin jdurgin jdurgin approved these changes

Assignees

No one assigned

Labels

mgr needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kamoltat @sebastian-philipp @liewegas @jdurgin @neha-ojha