Skip to content

[DNM] client: add more debug logs for setxattr#37174

Closed
lxbsz wants to merge 1 commit intoceph:masterfrom
lxbsz:dnm1
Closed

[DNM] client: add more debug logs for setxattr#37174
lxbsz wants to merge 1 commit intoceph:masterfrom
lxbsz:dnm1

Conversation

@lxbsz
Copy link
Member

@lxbsz lxbsz commented Sep 16, 2020

Just for testing to debug issues#47294.

For: https://tracker.ceph.com/issues/47294
Signed-off-by: Xiubo Li xiubli@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@lxbsz lxbsz requested a review from batrick September 16, 2020 01:48
@batrick
Copy link
Member

batrick commented Sep 22, 2020

jenkins test api

batrick added a commit to batrick/ceph that referenced this pull request Nov 7, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
@batrick
Copy link
Member

batrick commented Nov 16, 2020

@lxbsz please rebase.

For: https://tracker.ceph.com/issues/47294
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented Nov 17, 2020

@lxbsz please rebase.

Done. Thanks.

@batrick
Copy link
Member

batrick commented Nov 18, 2020

jenkins test docs

batrick added a commit to batrick/ceph that referenced this pull request Dec 21, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
batrick added a commit to batrick/ceph that referenced this pull request Dec 22, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
batrick added a commit to batrick/ceph that referenced this pull request Dec 22, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
batrick added a commit to batrick/ceph that referenced this pull request Dec 22, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
batrick added a commit to batrick/ceph that referenced this pull request Dec 22, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
batrick added a commit to batrick/ceph that referenced this pull request Dec 23, 2020
* refs/pull/37174/head:
	client: add more debug log for setxattr
@batrick
Copy link
Member

batrick commented Dec 24, 2020

Fix for this problem has been merged: https://tracker.ceph.com/issues/47294

Thanks @lxbsz

@batrick batrick closed this Dec 24, 2020
@batrick
Copy link
Member

batrick commented Jan 8, 2021

https://tracker.ceph.com/issues/47294 is back, reopening this for testing

@batrick batrick reopened this Jan 8, 2021
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and drop other debug lines. Then we can merge this.

// For setting pool of layout, MetaRequest need osdmap epoch.
// There is a race which create a new data pool but client and mds both don't have.
// Make client got the latest osdmap which make mds quickly judge whether get newer osdmap.
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
ldout(cct, 15) << __func__ << ": name=" << name << dendl;


if (r == -ENOENT) {
bs::error_code ec;
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
ldout(cct, 20) << __func__ << ": waiting for latest osdmap" << dendl;

bs::error_code ec;
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
objecter->wait_for_latest_osdmap(ca::use_blocked[ec]);
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ldout(cct, 1) << __func__ << ":" << __LINE__ << " name " << name << " value " << value << dendl;
ldout(cct, 20) << __func__ << ": finished waiting for latest osdmap: " << ec << dendl;

@batrick
Copy link
Member

batrick commented Jan 9, 2021

superseded by #38836

@batrick batrick closed this Jan 9, 2021
@lxbsz
Copy link
Member Author

lxbsz commented Jan 10, 2021

Sorry, missed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants