Skip to content

mgr/cephadm: Add CEPHADM_PAUSED to test_cli#35850

Merged
sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp:cephadm-set-paused-health
Jul 21, 2020
Merged

mgr/cephadm: Add CEPHADM_PAUSED to test_cli#35850
sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp:cephadm-set-paused-health

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Jun 30, 2020

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner June 30, 2020 13:14
mgfritch
mgfritch approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@mgfritch mgfritch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment for the serve() loop could be improved but otherwise looks good

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 1, 2020

green: https://pulpito.ceph.com/swagner-2020-07-01_10:16:24-rados:cephadm-wip-swagner3-testing-2020-07-01-1013-distro-basic-smithi/

still lots of failures:

@sebastian-philipp sebastian-philipp force-pushed the cephadm-set-paused-health branch from 70edd43 to 67dd2b4 Compare July 14, 2020 12:57
jschmid1
jschmid1 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@jschmid1 jschmid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus @mgfritch's suggested change

@sebastian-philipp sebastian-philipp force-pushed the cephadm-set-paused-health branch from 67dd2b4 to 219c4e5 Compare July 15, 2020 08:03
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 15, 2020

https://pulpito.ceph.com/swagner-2020-07-15_11:08:12-rados:cephadm-wip-swagner3-testing-2020-07-15-1008-distro-basic-smithi/

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 15, 2020 

flake8 create: /home/jenkins-build/build/workspace/ceph-pull-requests/qa/.tox/flake8
flake8 installdeps: flake8
WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
flake8 installed: -f /home/jenkins-build/build/workspace/ceph-pull-requests/qa/wheelhouse,flake8==3.8.3,importlib-metadata==1.7.0,mccabe==0.6.1,pycodestyle==2.6.0,pyflakes==2.2.0,zipp==3.1.0
flake8 run-test-pre: PYTHONHASHSEED='1607252996'
flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephadm_cases/test_cli.py:43:9: F841 local variable 'out' is assigned to but never used

@sebastian-philipp sebastian-philipp force-pushed the cephadm-set-paused-health branch from 219c4e5 to 836d0fc Compare July 15, 2020 13:16
@sebastian-philipp
mgr/cephadm: Add CEPHADM_PAUSED to test_cli
aee1aed 
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp force-pushed the cephadm-set-paused-health branch from 836d0fc to aee1aed Compare July 17, 2020 08:36
@sebastian-philipp sebastian-philipp added the wip-swagner-testing My Teuthology tests label Jul 17, 2020
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 17, 2020

jenkins test dashboard backend

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 20, 2020

https://pulpito.ceph.com/swagner-2020-07-20_10:53:40-rados:cephadm-wip-swagner-testing-2020-07-20-1103-distro-basic-smithi/

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 20, 2020

jenkins test dashboard backend

@sebastian-philipp sebastian-philipp added ready-to-merge and removed wip-swagner-testing My Teuthology tests labels Jul 20, 2020
@sebastian-philipp sebastian-philipp merged commit 120acb4 into ceph:master Jul 21, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgfritch mgfritch mgfritch approved these changes

@ricardoasmarques ricardoasmarques Awaiting requested review from ricardoasmarques

+1 more reviewer

@jschmid1 jschmid1 jschmid1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephadm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastian-philipp @mgfritch @jschmid1