Skip to content

cephadm: Retry pull on transient error#35846

Merged
sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp:podman-pull-retry
Jul 17, 2020
Merged

cephadm: Retry pull on transient error#35846
sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp:podman-pull-retry

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Jun 30, 2020 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/46271
Fixes: https://tracker.ceph.com/issues/46534

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner June 30, 2020 09:27
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 30, 2020

users might encounter "429 (Too Many Requests)". but I think this is out of scope for this PR for now.

smithfarm
smithfarm reviewed Jun 30, 2020
View reviewed changes
smithfarm
smithfarm reviewed Jun 30, 2020
View reviewed changes
smithfarm
smithfarm reviewed Jun 30, 2020
View reviewed changes
sebastian-philipp
sebastian-philipp commented Jul 1, 2020
View reviewed changes
This was referenced Jul 1, 2020
Merged
Merged
mgfritch
mgfritch reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@mgfritch mgfritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the is_available wrapper for this? see a5bb734

@sebastian-philipp
cephadm: Retry pull on transient error
f3e770f 
Fixes: https://tracker.ceph.com/issues/46271
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 14, 2020 •
edited
Loading

https://tracker.ceph.com/issues/46534

Digest did not match, expected

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 15, 2020

https://pulpito.ceph.com/swagner-2020-07-15_11:08:12-rados:cephadm-wip-swagner3-testing-2020-07-15-1008-distro-basic-smithi/

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 15, 2020 

============================== 10 passed in 0.15s ==============================
mypy create: /home/jenkins-build/build/workspace/ceph-pull-requests/src/cephadm/.tox/mypy
mypy installdeps: mypy==0.782
WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
mypy installed: -f /home/jenkins-build/build/workspace/ceph-pull-requests/src/cephadm/wheelhouse,mypy==0.782,mypy-extensions==0.4.3,typed-ast==1.4.1,typing-extensions==3.7.4.2
mypy run-test-pre: PYTHONHASHSEED='3143782481'
mypy run-test: commands[0] | mypy cephadm
cephadm:2363: error: Type signature has too few arguments
Found 1 error in 1 file (checked 1 source file)
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/cephadm/.tox/mypy/bin/mypy cephadm (exited with code 1)

@sebastian-philipp
cephadm: also retry on digest mismatch
ea080e6 
Fixes: https://tracker.ceph.com/issues/46534
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp added the wip-swagner-testing My Teuthology tests label Jul 16, 2020
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 16, 2020

https://pulpito.ceph.com/swagner-2020-07-16_14:28:11-rados:cephadm-wip-swagner-testing-2020-07-16-1149-distro-basic-smithi/

@sebastian-philipp sebastian-philipp added needs-review and removed wip-swagner-testing My Teuthology tests labels Jul 17, 2020
ricardoasmarques
ricardoasmarques approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jul 17, 2020

jenkins test dashboard backend

@sebastian-philipp sebastian-philipp merged commit b77b434 into ceph:master Jul 17, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgfritch mgfritch Awaiting requested review from mgfritch

2 more reviewers

@smithfarm smithfarm smithfarm left review comments

@ricardoasmarques ricardoasmarques ricardoasmarques approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephadm needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastian-philipp @mgfritch @smithfarm @ricardoasmarques