Skip to content

doc/cephadm: Add chapter about FQDNs#35412

Merged
sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp:doc-cephadm-concepts-fqdn
Jun 16, 2020
Merged

doc/cephadm: Add chapter about FQDNs#35412
sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp:doc-cephadm-concepts-fqdn

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Jun 5, 2020

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Taken from #34592 (comment)

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner June 5, 2020 10:43
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 5, 2020

todo for monday:

/home/jenkins-build/build/workspace/ceph-pr-docs/doc/cephadm/concepts.rst:26: WARNING: undefined label: cephadm-stry-host (if the link has no caption the label must precede a section header)
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/cephadm/operations.rst:221: WARNING: undefined label: cephad-fqdn (if the link has no caption the label must precede a section header)
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/mgr/orchestrator.rst:76: WARNING: undefined label: cephad-fqdn (if the link has no caption the label must precede a section header)

Daniel-Pivonka
Daniel-Pivonka reviewed Jun 5, 2020
View reviewed changes
doc/cephadm/concepts.rst Outdated
::

TODO: This chapter needs to provide way for users to configure
Grafana in the dashboard, as this is right no very hard to do. No newline at end of file
Copy link

@Daniel-Pivonka Daniel-Pivonka Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sentence doesn't sound right. maybe this is better "as this is right no very hard to do" -> "as this is very hard to do right now"

Copy link
Contributor

@zdover23 zdover23 Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the "TODO" is a note from Sebastian to Sebastian himself and no user will see it, this pull request is okay.

There are some minor changes to the English text that I would make if I were writing it, but those minor changes are not more important than approving this PR in its current state, which is sufficient to inform Ceph users of aspects of FQDN and Ceph.

I am therefore approving this pull request.

@zdover23 zdover23 self-assigned this Jun 8, 2020
zdover23
zdover23 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@zdover23 zdover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zdover23 pushed a commit to sebastian-philipp/ceph that referenced this pull request Jun 8, 2020
Add FQDN chapter to cephadm docs.
0b40ea5 
This PR supersedes the following PR and renders it void:

ceph#35412

Signed-off-by: Zac Dover <zac.dover@gmail.com>
@zdover23
Copy link
Contributor

zdover23 commented Jun 8, 2020

Actually, belay that. I've got to make some changes so that this builds correctly.

Stand by.

@sebastian-philipp sebastian-philipp force-pushed the doc-cephadm-concepts-fqdn branch from 506c82e to e48deb0 Compare June 9, 2020 08:52
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 9, 2020

jenkins render docs

toabctl
toabctl suggested changes Jun 11, 2020
View reviewed changes
@sebastian-philipp sebastian-philipp force-pushed the doc-cephadm-concepts-fqdn branch from e48deb0 to 3642c6d Compare June 11, 2020 12:21
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 11, 2020

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Jun 11, 2020

Doc render available at http://docs.ceph.com/ceph-prs/35412/

@sebastian-philipp sebastian-philipp force-pushed the doc-cephadm-concepts-fqdn branch from 3642c6d to 5dbaedb Compare June 11, 2020 13:40
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Jun 11, 2020

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Jun 11, 2020

Doc render available at http://docs.ceph.com/ceph-prs/35412/

toabctl
toabctl suggested changes Jun 15, 2020
View reviewed changes
doc/cephadm/concepts.rst
``ceph orch host add <bare-name>``.

..
TODO: This chapter needs to provide way for users to configure
Copy link
Contributor

@toabctl toabctl Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that comment really valid here?

Copy link
Contributor Author

@sebastian-philipp sebastian-philipp Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we need to provide users a way to properly design their environment such that a valid grafana deployment is possible.

@sebastian-philipp
doc/cephadm: Add chapter about FQDNs
55e608d 
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp force-pushed the doc-cephadm-concepts-fqdn branch from 5dbaedb to 55e608d Compare June 15, 2020 13:26
@sebastian-philipp sebastian-philipp merged commit 38e79b6 into ceph:master Jun 16, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdover23 zdover23 zdover23 approved these changes

@pcuzner pcuzner Awaiting requested review from pcuzner

@epuertat epuertat Awaiting requested review from epuertat

+2 more reviewers

@Daniel-Pivonka Daniel-Pivonka Daniel-Pivonka left review comments

@toabctl toabctl toabctl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zdover23 zdover23

Labels

cephadm documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastian-philipp @zdover23 @ceph-jenkins @toabctl @Daniel-Pivonka