Skip to content

vstart: Support deployment of ganesha daemon by cephadm with NFS option#35344

Merged
batrick merged 2 commits intoceph:masterfrom
varshar16:wip-deploy-dummy-ganesha-daemons-vstart
Jun 8, 2020
Merged

vstart: Support deployment of ganesha daemon by cephadm with NFS option#35344
batrick merged 2 commits intoceph:masterfrom
varshar16:wip-deploy-dummy-ganesha-daemons-vstart

Conversation

@varshar16
Copy link
Contributor

@varshar16 varshar16 commented Jun 2, 2020 •
edited
Loading

NFS Ganesha cluster can be created in two ways with vstart
cluster:

  1. With test_orchestrator
    NFS=1 ../src/vstart.sh
    This type of deployment can have multiple ganesha daemons on random port.

  2. With Cephadm
    NFS=1 ../src/vstart.sh --cephadm
    It can deploy only single ganesha daemon with vstart on default ganesha port.

Both can create multiple cephfs exports.

Fixes: https://tracker.ceph.com/issues/45830

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@varshar16 varshar16 requested a review from a team as a code owner June 2, 2020 10:37
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Jun 2, 2020

ack.

batrick
batrick previously requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want to be able to do this in Octopus too. Please create a tracker ticket so it can be backported.

varshar16 added a commit to varshar16/ceph that referenced this pull request Jun 3, 2020
@varshar16
vstart: Support deployment of ganesha daemon by cephadm with NFS option.
bb449ea 
NFS Ganesha cluster can be created in two ways with vstart
cluster:

1) With test_orchestrator
NFS=1 ../src/vstart.sh
This type of deployment can have multiple ganesha daemons on random port.

2) With Cephadm
NFS=1 ../src/vstart.sh --cephadm
It can deploy only single ganesha daemon with vstart on default ganesha port.

Both can create multiple cephfs exports.

Fixes: ceph#35344
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16 varshar16 force-pushed the wip-deploy-dummy-ganesha-daemons-vstart branch 2 times, most recently from bb449ea to df67954 Compare June 3, 2020 04:58
@varshar16 varshar16 requested a review from batrick June 3, 2020 04:59
@epuertat epuertat requested a review from alfonsomthd June 3, 2020 20:00
mgfritch
mgfritch approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@mgfritch mgfritch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions for dummy_data.json, otherwise looks good!

@alfonsomthd
Copy link
Contributor

alfonsomthd commented Jun 5, 2020

jenkins test dashboard backend

@alfonsomthd alfonsomthd requested a review from jmolmo June 5, 2020 07:17
@jmolmo
Copy link
Member

jmolmo commented Jun 5, 2020

Maybe i miss something ... but i do not understand well this change.
the thing to solve is:
"vstart: Support deployment of ganesha daemon by cephadm with NFS option"

and in the code modifications i only can see a Ceph nfs setup with the "test_orchestrator" enabled.
Cephadm orchestrator is not used here in any place, and for sure that a nfs daemon is not deployed with cephadm... (which is the thing that it seems the bug title suggest to do)

@jmolmo
Copy link
Member

jmolmo commented Jun 5, 2020

Maybe i miss something ... but i do not understand well this change.
the thing to solve is:
"vstart: Support deployment of ganesha daemon by cephadm with NFS option"

and in the code modifications i only can see a Ceph nfs setup with the "test_orchestrator" enabled.
Cephadm orchestrator is not used here in any place, and for sure that a nfs daemon is not deployed with cephadm... (which is the thing that it seems the bug title suggest to do)

ok. I think i know what is the motivation... just trying to simulate the cephadm behaviour.

varshar16 added 2 commits June 5, 2020 16:58
@varshar16
mgr/test_orchestrator: List nfs daemon
a104405 
This patch adds dummy data for nfs ganesha daemon and adds nfs to list of
supported service type.

Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16
vstart: Support deployment of ganesha daemon by cephadm with NFS option.
1896b70 
NFS Ganesha cluster can be created in two ways with vstart
cluster:

1) With test_orchestrator
NFS=1 ../src/vstart.sh
This type of deployment can have multiple ganesha daemons on random port.

2) With Cephadm
NFS=1 ../src/vstart.sh --cephadm
It can deploy only single ganesha daemon with vstart on default ganesha port.

Both can create multiple cephfs exports.

Fixes: https://tracker.ceph.com/issues/45830
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16 varshar16 force-pushed the wip-deploy-dummy-ganesha-daemons-vstart branch from df67954 to 1896b70 Compare June 5, 2020 11:29
@varshar16
Copy link
Contributor Author

varshar16 commented Jun 5, 2020

Maybe i miss something ... but i do not understand well this change.
the thing to solve is:
"vstart: Support deployment of ganesha daemon by cephadm with NFS option"
and in the code modifications i only can see a Ceph nfs setup with the "test_orchestrator" enabled.
Cephadm orchestrator is not used here in any place, and for sure that a nfs daemon is not deployed with cephadm... (which is the thing that it seems the bug title suggest to do)

ok. I think i know what is the motivation... just trying to simulate the cephadm behaviour.

You are partially correct.

If cephadm is enabled then volume's nfs interface calls orchestrator to deploy ganesha daemons.
Otherwise as you said test_orchestrator simulates cephadm behaviour.

@varshar16 varshar16 mentioned this pull request Jun 5, 2020
Merged
ajarr
ajarr approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@ajarr ajarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajarr ajarr dismissed batrick’s stale review June 8, 2020 12:09

tracker ticket in octopus has been created

@ajarr ajarr added the needs-qa label Jun 8, 2020
@ajarr ajarr removed the needs-review label Jun 8, 2020
@ajarr
Copy link
Contributor

ajarr commented Jun 8, 2020

@batrick this PR is good to merge. I don't think this PR can be tested in teuthology. It works for me locally with vstart.

@batrick
Copy link
Member

batrick commented Jun 8, 2020

jenkins test dashboard

@batrick batrick merged commit 67f58e5 into ceph:master Jun 8, 2020
@varshar16 varshar16 mentioned this pull request Jun 9, 2020
Merged
@varshar16 varshar16 deleted the wip-deploy-dummy-ganesha-daemons-vstart branch June 26, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@mgfritch mgfritch mgfritch approved these changes

@ajarr ajarr ajarr approved these changes

@sebastian-philipp sebastian-philipp Awaiting requested review from sebastian-philipp

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

@jmolmo jmolmo Awaiting requested review from jmolmo

+1 more reviewer

@jtlayton jtlayton jtlayton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephadm cephfs Ceph File System needs-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@varshar16 @sebastian-philipp @alfonsomthd @jmolmo @ajarr @batrick @mgfritch @jtlayton