Conversation
The original trim header update code was using blocking IO to update the header. After migrating to an asynchronous trim which performs all work in librados callbacks, it exposed a potential deadlock in the librados_test_stub when attempting to do blocking IO within a librados callback. This commit changes the header update to use AIO. Fixes: #10637 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for 22bbf5f is http://paste2.org/_5ADwJIwW |
Sent from
jdurgin
added a commit
that referenced
this pull request
Jan 26, 2015
librbd: trim header update not using AIO Reviewed-by: Josh Durgin <jdurgin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original trim header update code was using blocking IO to
update the header. After migrating to an asynchronous trim
which performs all work in librados callbacks, it exposed a
potential deadlock in the librados_test_stub when attempting
to do blocking IO within a librados callback. This commit
changes the header update to use AIO.
Fixes: #10637
Signed-off-by: Jason Dillaman dillaman@redhat.com