mgr/DaemonServer: fetch metadata for new daemons (e.g., mons)#34266
Merged
liewegas merged 1 commit intoceph:masterfrom Mar 30, 2020
Merged
mgr/DaemonServer: fetch metadata for new daemons (e.g., mons)#34266liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
We fetch metadata for mon/osd/mds daemons on startup. If a new one comes along *after* we start up, we need to fetch it on demand. Otherwise, notably, we will ignore any new mons added to the cluster: - mon.a starts - mgr starts, fetchs a's metadata - mon.b added - mon.b tries top open mgr connection, and is rejected each time This can lead to follow-on badness when the mon tries to proxy mgr commands or do other things. Fix by fetching metadata on demand, like we already do in the report path. Fixes: https://tracker.ceph.com/issues/44798 Signed-off-by: Sage Weil <sage@redhat.com>
Member
Author
neha-ojha
approved these changes
Mar 29, 2020
tchaikov
reviewed
Mar 30, 2020
Contributor
tchaikov
left a comment
There was a problem hiding this comment.
ideally, we should break this commit into two. one to extract the code fetching metadata into fetch_missing_metadata(), another to call this method in fetch_missing_metadata(). also, i think it still makes sense to have ceph_abort(); if the key.type is not known.
Member
Author
Sorry, didn't see this before. I didn't noticed this was nested inside conditional checking the type. I can add the abort back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fetch metadata for mon/osd/mds daemons on startup. If a new one comes
along after we start up, we need to fetch it on demand. Otherwise,
notably, we will ignore any new mons added to the cluster:
This can lead to follow-on badness when the mon tries to proxy mgr
commands or do other things.
Fix by fetching metadata on demand, like we already do in the report
path.
Fixes: https://tracker.ceph.com/issues/44798
Signed-off-by: Sage Weil sage@redhat.com