qa/tasks/cephadm: fix ceph.conf so it includes *all* mons#34248
Merged
liewegas merged 3 commits intoceph:masterfrom Mar 30, 2020
Merged
qa/tasks/cephadm: fix ceph.conf so it includes *all* mons#34248liewegas merged 3 commits intoceph:masterfrom
liewegas merged 3 commits intoceph:masterfrom
Conversation
Revert part of 96220c0 so that we still distribute a *final* ceph.conf and admin keyring to all nodes, right after all of the mons are up. Signed-off-by: Sage Weil <sage@redhat.com>
Otherwise we'll distribute the initial ceph.conf, which only has the bootstrap mon in it. Signed-off-by: Sage Weil <sage@redhat.com>
cephadm does this magically now. Signed-off-by: Sage Weil <sage@redhat.com>
Contributor
|
Hm, to me this looks more like a bug in cephadm itself. if cephadm cannot properly refresh the ceph.conf, something is broken? |
Member
Author
This is is the ceph.conf outside of the container, on the host. We haven't designed/implemented anything to manage that (or, say, installed packages) on the host yet. |
Member
Author
|
(I agree that cephadm should have a way to manage ceph.conf files outside of the containers themselves, though... just not sure how to approach that problem.) |
Contributor
sebastian-philipp
approved these changes
Mar 27, 2020
Member
Author
|
exposes bug fixed by #34266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs backport to octopus