Skip to content

mgr/cephadm: replace async_map_completion with a simple wrapper#34091

Merged
liewegas merged 3 commits intoceph:masterfrom
sebastian-philipp:cephadm-remove-async-map
Mar 26, 2020
Merged

mgr/cephadm: replace async_map_completion with a simple wrapper#34091
liewegas merged 3 commits intoceph:masterfrom
sebastian-philipp:cephadm-remove-async-map

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Mar 20, 2020

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@sebastian-philipp sebastian-philipp requested a review from a team as a code owner March 20, 2020 16:49
liewegas
liewegas reviewed Mar 20, 2020
View reviewed changes
liewegas
liewegas reviewed Mar 20, 2020
View reviewed changes
liewegas
liewegas reviewed Mar 20, 2020
View reviewed changes
@liewegas
Copy link
Member

liewegas commented Mar 24, 2020 

cephadm/module.py: note: In function "forall_hosts_wrapper":
cephadm/module.py:485: error: Item "None" of "Optional[CephadmOrchestrator]" has no attribute "_worker_pool"

@sebastian-philipp
mgr/cephadm: replace async_map_completion with a simple wrapper
a78f42e 
There is no need to wrap everything into completions.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp
mgr/cephadm: replace async_completion with trivial_completion
29aa87c 
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp
mgr/cephadm: cleanup async_map_completion etc.
d8ced20 
This breaks the progress integration, but we haven't
used that anyway till now.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp force-pushed the cephadm-remove-async-map branch from 377f5ac to d8ced20 Compare March 25, 2020 11:07
@liewegas liewegas merged commit f865f3e into ceph:master Mar 26, 2020
@liewegas liewegas mentioned this pull request Mar 26, 2020
Closed
sebastian-philipp added a commit to sebastian-philipp/ceph that referenced this pull request Mar 26, 2020
@sebastian-philipp
mgr/cephadm: Add missing decorator
8e90f31 
Caused by a conflict between

* ceph#33581 (770816d) and
* ceph#34091 (a78f42e)

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp sebastian-philipp mentioned this pull request Mar 26, 2020
Merged
3 tasks
liewegas added a commit to liewegas/ceph that referenced this pull request Mar 28, 2020
@liewegas
Revert "Merge PR ceph#34091 into master"
af8fa11 
This reverts commit f865f3e, reversing
changes made to 7ef5458.

Signed-off-by: Sage Weil <sage@redhat.com>
liewegas added a commit that referenced this pull request Mar 30, 2020
@liewegas
Merge PR #34260 into master
07d9231 
* refs/pull/34260/head:
	Revert "Merge PR #34091 into master"

Reviewed-by: Sebastian Wagner <swagner@suse.com>
@sebastian-philipp sebastian-philipp mentioned this pull request May 7, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liewegas liewegas liewegas left review comments

Assignees

No one assigned

Labels

cephadm needs-qa wip-sage3-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebastian-philipp @liewegas