nautilus: rgw multisite: set entry to lc index of slave when syncing#33524
Closed
IlsooByun wants to merge 1 commit intoceph:nautilusfrom
Closed
nautilus: rgw multisite: set entry to lc index of slave when syncing#33524IlsooByun wants to merge 1 commit intoceph:nautilusfrom
IlsooByun wants to merge 1 commit intoceph:nautilusfrom
Conversation
Signed-off-by: Ilsoo Byun <ilsoobyun@linecorp.com>
67ac993 to
712b746
Compare
Contributor
|
jenkins test make check |
Contributor
|
@IlsooByun Can you explain - in the commit message, not in a PR comment - why it is not feasible to fix the issue in master/octopus, first, and then cherry-pick it from there to nautilus? |
smithfarm
suggested changes
Mar 19, 2020
Contributor
smithfarm
left a comment
There was a problem hiding this comment.
Not clear why it's not a cherry-pick from master
Contributor
Author
Sorry for the confusion. Since I am currently using Nautilus in my cluster, I made a patch for Nautilus. I have not yet tested this patch on the master. Would it be better to rewrite this patch for the master? |
Contributor
yes please! we do all development and testing on master, and backport from there as necessary |
3 tasks
Contributor
|
adding DNM until:
|
Contributor
|
The master PR #34553 is still open, and is going stale. If and when it merges, we can rely on the regular backporting workflows to create the nautilus backport PR correctly, because the ticket https://tracker.ceph.com/issues/44268 is marked for backport to nautilus. Closing as premature. |
mattbenjamin
added a commit
to linuxbox2/ceph
that referenced
this pull request
Jul 5, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
added a commit
to linuxbox2/ceph
that referenced
this pull request
Jul 5, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
added a commit
to linuxbox2/ceph
that referenced
this pull request
Jul 15, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
added a commit
to linuxbox2/ceph
that referenced
this pull request
Jul 17, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Jul 21, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! This downstream backport borrows code from the upstream Role replication work by Pritha Srivastava <prsrivas@redhat.com>, which allows to access an rgw::sal::Store (here RGWRadosStore) from a metadata handler. Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Resolves: rhbz#2095670 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 2ee2266) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Aug 7, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! This downstream backport borrows code from the upstream Role replication work by Pritha Srivastava <prsrivas@redhat.com>, which allows to access an rgw::sal::Store (here RGWRadosStore) from a metadata handler. Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Resolves: rhbz#2095670 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 2ee2266) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Sep 26, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! This downstream backport borrows code from the upstream Role replication work by Pritha Srivastava <prsrivas@redhat.com>, which allows to access an rgw::sal::Store (here RGWRadosStore) from a metadata handler. Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Resolves: rhbz#2095670 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 2ee2266) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Pegonzal
pushed a commit
that referenced
this pull request
Oct 13, 2022
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: #33524 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Jan 2, 2023
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Resolves: rhbz#2095670 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 2ee2266) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
aaSharma14
pushed a commit
to aaSharma14/ceph
that referenced
this pull request
Apr 14, 2023
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Resolves: rhbz#2095670 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 2ee2266) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
trociny
pushed a commit
to trociny/ceph
that referenced
this pull request
Dec 12, 2023
The basic idea of this change is the same as the proposal by Ilsoo Byun <ilsoobyun@linecorp.com>, but some details have changed. The main differences are to use the existing RGWLC::set(remove)_bucket_config methods, and to use the RGWBucketInstanceMetadataHandler infrastructue to dispatch the corresponding calls. Thank you! Fixes: https://tracker.ceph.com/issues/44268 Related PR: ceph#33524 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 2ee2266)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/44268
Signed-off-by: Ilsoo Byun ilsoobyun@linecorp.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox