msg/Policy: limit unregistered anon connections to mon#33163
Merged
liewegas merged 1 commit intoceph:masterfrom Feb 15, 2020
Merged
msg/Policy: limit unregistered anon connections to mon#33163liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
When we were fixing 'tell mon' we changed the messenger to allow multiple lossy connections to the same server. This was needed for the mon, and assumed to be harmless for everyone else. However, for the OSD, it can lead to out-of-order requests, as observed in this bug: https://tracker.ceph.com/issues/42328 Fix by reverting this behavior change except for the mon: - Introduce a stateless_anon_server policy that sets register_lossy_clients = false - Effectively revert the behavior change in c48a29b so that lossy clients *are* registered for stateless_server policy. - Use the state_anon_server policy for the mon, which was the one place where we needed unregistered connections (for 'tell mon.x' to work). Fixes: https://tracker.ceph.com/issues/42328 Signed-off-by: Sage Weil <sage@redhat.com>
neha-ojha
approved these changes
Feb 10, 2020
liewegas
added a commit
that referenced
this pull request
Feb 15, 2020
* refs/pull/33163/head: msg/Policy: limit unregistered anon connections to mon Reviewed-by: Neha Ojha <nojha@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we were fixing 'tell mon' we changed the messenger to allow multiple
lossy connections to the same server. This was needed for the mon, and
assumed to be harmless for everyone else. However, for the OSD, it can
lead to out-of-order requests, as observed in this bug:
https://tracker.ceph.com/issues/42328
Fix by reverting this behavior change except for the mon:
Introduce a stateless_anon_server policy that sets
register_lossy_clients = false
Effectively revert the behavior change in c48a29b
so that lossy clients are registered for stateless_server policy.
Use the state_anon_server policy for the mon, which was the one place
where we needed unregistered connections (for 'tell mon.x' to work).
Fixes: https://tracker.ceph.com/issues/42328
Signed-off-by: Sage Weil sage@redhat.com