mon: elector: return after triggering a new election#32981
Merged
liewegas merged 1 commit intoceph:masterfrom Jan 31, 2020
Merged
mon: elector: return after triggering a new election#32981liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
When receiving an old propose, we were correctly triggering a new election but not then returning out of receive_propose(), so we processed the "should I defer" logic and perhaps sent out a deferal (in the current epoch!). Fixes: https://tracker.ceph.com/issues/42977 Signed-off-by: Greg Farnum <gfarnum@redhat.com>
e875a3a to
337d12b
Compare
liewegas
approved these changes
Jan 30, 2020
neha-ojha
approved these changes
Jan 30, 2020
liewegas
added a commit
that referenced
this pull request
Jan 31, 2020
* refs/pull/32981/head: mon: elector: return after triggering a new election Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Neha Ojha <nojha@redhat.com>
Contributor
|
@liewegas In the tracker Greg mentioned that this should probably be backported to nautilus - do you not agree? |
Member
Oops! I didn't see that comment and assumed this was a new regression from the recent changes. Backport away! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When receiving an old propose, we were correctly triggering a new election
but not then returning out of receive_propose(), so we processed the
"should I defer" logic and perhaps sent out a deferal (in the current epoch!).
Fixes: https://tracker.ceph.com/issues/42977
Signed-off-by: Greg Farnum gfarnum@redhat.com