Skip to content

Create and delete exports for nfs ganesha with mgr volume #32297

Merged
sebastian-philipp merged 31 commits intoceph:masterfrom
varshar16:wip-mgr-nfs-ganesha-exports
Apr 11, 2020
Merged

Create and delete exports for nfs ganesha with mgr volume #32297
sebastian-philipp merged 31 commits intoceph:masterfrom
varshar16:wip-mgr-nfs-ganesha-exports

Conversation

@varshar16
Copy link
Contributor

@varshar16 varshar16 commented Dec 17, 2019 •
edited
Loading

$ ceph nfs cluster create <type=cephfs> [--size=1] <clusterid>

This creates an nfs cluster.
clusterid: It is cluster name
size: Cluster size

$ ceph nfs export create <type=cephfs> <fsname> <binding> <clusterid> [--readonly] [--path=/path/in/cephfs]

This command creates cephfs exports for nfs-ganesha. Here binding is the pseudo root name.

Using vstart both ganesha daemons and exports are created:
MDS=1 MON=1 OSD=3 NFS=1 ../src/vstart.sh -n -d

After vstart runs successfully, mount cephfs based on Ganesha IP address and port in ceph.conf.
mount -t nfs -o port=44581 192.168.1.38:/cephfs /mnt

Note: mgr should be enabled and vstart can create multiple clusters each with single export.

This patch is based on this PR #31527.

Fixes: https://tracker.ceph.com/issues/44193

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@varshar16 varshar16 force-pushed the wip-mgr-nfs-ganesha-exports branch from d748fc2 to b80ad83 Compare December 18, 2019 15:23
@varshar16
Copy link
Contributor Author

varshar16 commented Dec 18, 2019

Rebased

@varshar16
Copy link
Contributor Author

varshar16 commented Dec 19, 2019

jenkins retest this please

@varshar16 varshar16 force-pushed the wip-mgr-nfs-ganesha-exports branch from b80ad83 to 164f44f Compare December 19, 2019 12:19
@varshar16 varshar16 changed the title Create exports for nfs ganesha with mgr volume Create and delete exports for nfs ganesha with mgr volume Dec 19, 2019
@varshar16
Copy link
Contributor Author

varshar16 commented Dec 19, 2019

Added command to delete export.

batrick
batrick requested changes Jan 9, 2020
View reviewed changes
@batrick
Copy link
Member

batrick commented Feb 18, 2020

Please add this tracker ticket: https://tracker.ceph.com/issues/44193

@varshar16 varshar16 force-pushed the wip-mgr-nfs-ganesha-exports branch from 164f44f to b2f250d Compare February 25, 2020 14:23
@varshar16
Copy link
Contributor Author

varshar16 commented Feb 25, 2020

Please add this tracker ticket: https://tracker.ceph.com/issues/44193

Done.

@varshar16
Copy link
Contributor Author

varshar16 commented Feb 25, 2020

jenkins render docs

@varshar16
Copy link
Contributor Author

varshar16 commented Feb 25, 2020

It can create single cluster and export. For more than one export and cluster, it requires some modifications.

@varshar16
Copy link
Contributor Author

varshar16 commented Feb 26, 2020

jenkins render docs

@varshar16 varshar16 force-pushed the wip-mgr-nfs-ganesha-exports branch from b2f250d to b5afec1 Compare February 28, 2020 12:43
@varshar16 varshar16 requested a review from a team as a code owner February 28, 2020 12:43
@varshar16 varshar16 removed the request for review from a team February 28, 2020 12:44
@varshar16
Copy link
Contributor Author

varshar16 commented Feb 28, 2020

jenkins render docs

sebastian-philipp
sebastian-philipp reviewed Feb 28, 2020
View reviewed changes
sebastian-philipp
sebastian-philipp reviewed Feb 28, 2020
View reviewed changes
@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Feb 28, 2020

Doc render available at http://docs.ceph.com/ceph-prs/32297/

@varshar16 varshar16 force-pushed the wip-mgr-nfs-ganesha-exports branch from b5afec1 to ace77b7 Compare February 28, 2020 15:06
@varshar16
Copy link
Contributor Author

varshar16 commented Feb 28, 2020

jenkins render docs

varshar16 added 3 commits April 8, 2020 17:21
@varshar16
mgr/volumes: Make cluster id option mandatory in nfs create export
25642bc 
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16
mgr/volumes: Remove unused typing module
14cbf6d 
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16
mgr/volumes: Add a note about placement option in nfs cluster create
e3da102 
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16 varshar16 force-pushed the wip-mgr-nfs-ganesha-exports branch from 945616b to e3da102 Compare April 8, 2020 11:51
@varshar16
Copy link
Contributor Author

varshar16 commented Apr 8, 2020

Fixed spacing issue in doc.

@varshar16
Copy link
Contributor Author

varshar16 commented Apr 8, 2020

jenkins render docs

@jtlayton jtlayton requested a review from gregsfortytwo April 8, 2020 13:48
jtlayton
jtlayton approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks usable now to me, and I think we'll want to go ahead and merge it and then sort out the remaining details afterward. Since the bulk of this is mgr code, I think we might need to get someone involved in that code to rubber-stamp this. @sebastian-philipp : who would be best to give this a look before merge?

@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Apr 8, 2020

@sebastian-philipp : who would be best to give this a look before merge?

As long as Patrick is on leave: you and Mike. both approved it. let's get this in.

@mgfritch
Copy link
Contributor

mgfritch commented Apr 9, 2020

jenkins render docs

@mgfritch
Copy link
Contributor

mgfritch commented Apr 9, 2020

http://pulpito.ceph.com/mgfritch-2020-04-09_00:50:50-rados-wip-mgfritch-testing-2020-04-08-1723-distro-basic-smithi/

@varshar16
Copy link
Contributor Author

varshar16 commented Apr 9, 2020

jenkins retest this please

1 similar comment
@varshar16
Copy link
Contributor Author

varshar16 commented Apr 9, 2020

jenkins retest this please

@jtlayton
Copy link
Contributor

jtlayton commented Apr 9, 2020

Looks good. @varshar16 is going to run one more testsuite against it, and we'll merge soon afterward.

@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Apr 9, 2020

Looks good. @varshar16 is going to run one more testsuite against it, and we'll merge soon afterward.

which ones? For cephadm, I'm typically running -suite rados --filter cephadm --subset x/9999

@varshar16
Copy link
Contributor Author

varshar16 commented Apr 9, 2020

Looks good. @varshar16 is going to run one more testsuite against it, and we'll merge soon afterward.

which ones? For cephadm, I'm typically running -suite rados --filter cephadm --subset x/9999

I am just running fs volume tests.

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Apr 10, 2020

Doc render available at http://docs.ceph.com/ceph-prs/32297/

@varshar16
Copy link
Contributor Author

varshar16 commented Apr 10, 2020

http://pulpito.ceph.com/varsha-2020-04-10_05:49:34-fs-wip-varsha-testing-distro-basic-smithi/

@varshar16
Copy link
Contributor Author

varshar16 commented Apr 10, 2020

@jtlayton the tests have passed.

@sebastian-philipp sebastian-philipp merged commit 62abead into ceph:master Apr 11, 2020
@varshar16 varshar16 deleted the wip-mgr-nfs-ganesha-exports branch April 30, 2020 10:15
@varshar16 varshar16 restored the wip-mgr-nfs-ganesha-exports branch June 1, 2020 07:11
@varshar16 varshar16 mentioned this pull request Jun 9, 2020
Merged
@varshar16 varshar16 deleted the wip-mgr-nfs-ganesha-exports branch June 26, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgfritch mgfritch mgfritch approved these changes

@fullerdj fullerdj Awaiting requested review from fullerdj

@ajarr ajarr Awaiting requested review from ajarr

@batrick batrick Awaiting requested review from batrick

@liewegas liewegas Awaiting requested review from liewegas

@gregsfortytwo gregsfortytwo Awaiting requested review from gregsfortytwo

+2 more reviewers

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

@jtlayton jtlayton jtlayton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@varshar16 varshar16

Labels

cephfs Ceph File System feature mgr needs-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@varshar16 @batrick @ceph-jenkins @mgfritch @sebastian-philipp @jtlayton @liewegas