Skip to content

Deploy ganesha daemons with vstart#31527

Merged
batrick merged 3 commits intoceph:masterfrom
varshar16:wip-vstart-ganesha-daemons
Dec 18, 2019
Merged

Deploy ganesha daemons with vstart#31527
batrick merged 3 commits intoceph:masterfrom
varshar16:wip-vstart-ganesha-daemons

Conversation

@varshar16
Copy link
Contributor

@varshar16 varshar16 commented Nov 11, 2019 •
edited
Loading

To create Ganesha daemons with vstart following packages needs to be installed:
nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

This patch is tested on fedora 30 system with packages version 2.7.6-2.

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@varshar16 varshar16 added cephfs Ceph File System needs-review labels Nov 11, 2019
jtlayton
jtlayton suggested changes Nov 11, 2019
View reviewed changes
@varshar16 varshar16 force-pushed the wip-vstart-ganesha-daemons branch from 88f70e9 to d2a1f09 Compare November 11, 2019 15:31
@varshar16 varshar16 requested a review from jtlayton November 11, 2019 15:35
@varshar16 varshar16 force-pushed the wip-vstart-ganesha-daemons branch from d2a1f09 to 3b32b85 Compare November 12, 2019 11:01
ajarr
ajarr reviewed Nov 12, 2019
View reviewed changes
Copy link
Contributor

@ajarr ajarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a later PR it'd be good to indicate to the user the nfs-ganesha packages that might be missing.

src/vstart.sh Outdated
EOF
prun $CEPH_BIN/rados lspools

prun ganesha-rados-grace -p cephfs.a.meta -n ganesha add $name
Copy link
Contributor

@ajarr ajarr Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone tries to deploy ganesha servers using vstart without deploying MDSes this will fail. Can we check early on whether vstart deploys ganesha servers along with MDSes, and error out if it isn't so?

Or maybe we should just create an another pool here 'nfs-ganesha' and use that?

Copy link
Contributor Author

@varshar16 varshar16 Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created new pool for ganesha.

@varshar16 varshar16 force-pushed the wip-vstart-ganesha-daemons branch from 3b32b85 to b6732c6 Compare November 13, 2019 07:29
@varshar16 varshar16 requested a review from ajarr November 13, 2019 07:30
@varshar16
Copy link
Contributor Author

varshar16 commented Nov 14, 2019

jenkins retest this please

@varshar16 varshar16 force-pushed the wip-vstart-ganesha-daemons branch from b6732c6 to e79b975 Compare November 15, 2019 10:05
@varshar16
Copy link
Contributor Author

varshar16 commented Nov 15, 2019

Disabled root squashing.

@jtlayton jtlayton self-requested a review November 15, 2019 11:18
jtlayton
jtlayton approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work @varshar16 !

@varshar16
Copy link
Contributor Author

varshar16 commented Nov 15, 2019

Thank you for the reviews Jeff and Ramana.

@batrick
Copy link
Member

batrick commented Nov 25, 2019

nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Where are you testing this PR? I don't find these packages available on CentOS 8 or Ubuntu 16.04.

@varshar16
Copy link
Contributor Author

varshar16 commented Nov 28, 2019

nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Where are you testing this PR? I don't find these packages available on CentOS 8 or Ubuntu 16.04.

I tested them on Fedora 30 and package version is 2.7.6-2. For CentOS 8 the packages are available here and Ubuntu 16.04 check here. On Ubuntu I only found nfs-ganesha package.

@batrick
Copy link
Member

batrick commented Dec 5, 2019

nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Where are you testing this PR? I don't find these packages available on CentOS 8 or Ubuntu 16.04.

I tested them on Fedora 30 and package version is 2.7.6-2. For CentOS 8 the packages are available here and Ubuntu 16.04 check here. On Ubuntu I only found nfs-ganesha package.

Okay, so we need the upstream repo. Can you add instructions for doing that to vstart in a comment so others know what to setup/install.

@varshar16
Copy link
Contributor Author

varshar16 commented Dec 6, 2019

nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Where are you testing this PR? I don't find these packages available on CentOS 8 or Ubuntu 16.04.

I tested them on Fedora 30 and package version is 2.7.6-2. For CentOS 8 the packages are available here and Ubuntu 16.04 check here. On Ubuntu I only found nfs-ganesha package.

Okay, so we need the upstream repo. Can you add instructions for doing that to vstart in a comment so others know what to setup/install.

I have updated the initial PR comment. Let me know if it is fine.

@batrick
Copy link
Member

batrick commented Dec 12, 2019

nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Where are you testing this PR? I don't find these packages available on CentOS 8 or Ubuntu 16.04.

I tested them on Fedora 30 and package version is 2.7.6-2. For CentOS 8 the packages are available here and Ubuntu 16.04 check here. On Ubuntu I only found nfs-ganesha package.

Okay, so we need the upstream repo. Can you add instructions for doing that to vstart in a comment so others know what to setup/install.

I have updated the initial PR comment. Let me know if it is fine.

I mean please add instructions to setup the dev repositories https://download.nfs-ganesha.org/2.7/2.7.6/ in order to install the packages. This could be a comment in vstart.sh

@varshar16
vstart: Add option to deploy ganesha daemons
11b4227 
To create Ganesha daemons with vstart following packages needs to be installed:
nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Version used for these packages 2.7.6-2 on fedora 30 system.

This is an experimental option, it just deploys specified number of ganesha
daemons.

Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16
stop.sh: Add option to kill Ganesha daemons
c5fbbe9 
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16
vstart: Add note for nfs-ganesha dev packages
b303e48 
Signed-off-by: Varsha Rao <varao@redhat.com>
@varshar16 varshar16 force-pushed the wip-vstart-ganesha-daemons branch from e79b975 to b303e48 Compare December 17, 2019 11:40
@varshar16
Copy link
Contributor Author

varshar16 commented Dec 17, 2019 •
edited
Loading

nfs-ganesha nfs-ganesha-ceph nfs-ganesha-rados-grace

Where are you testing this PR? I don't find these packages available on CentOS 8 or Ubuntu 16.04.

I tested them on Fedora 30 and package version is 2.7.6-2. For CentOS 8 the packages are available here and Ubuntu 16.04 check here. On Ubuntu I only found nfs-ganesha package.

Okay, so we need the upstream repo. Can you add instructions for doing that to vstart in a comment so others know what to setup/install.

I have updated the initial PR comment. Let me know if it is fine.

I mean please add instructions to setup the dev repositories https://download.nfs-ganesha.org/2.7/2.7.6/ in order to install the packages. This could be a comment in vstart.sh

I have added them.

@varshar16 varshar16 mentioned this pull request Dec 17, 2019
Merged
batrick
batrick approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

batrick added a commit that referenced this pull request Dec 18, 2019
@batrick
Merge PR #31527 into master
f2f53ee 
* refs/pull/31527/head:
	vstart: Add note for nfs-ganesha dev packages
	stop.sh: Add option to kill Ganesha daemons
	vstart: Add option to deploy ganesha daemons

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
@batrick batrick merged commit b303e48 into ceph:master Dec 18, 2019
@varshar16 varshar16 deleted the wip-vstart-ganesha-daemons branch January 14, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@ajarr ajarr ajarr approved these changes

@fullerdj fullerdj Awaiting requested review from fullerdj

+1 more reviewer

@jtlayton jtlayton jtlayton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephfs Ceph File System needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@varshar16 @batrick @ajarr @jtlayton