Skip to content

mgr/test_orchestrator: Add dummy data#32182

Merged
sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp:upstream-pull-31757
Dec 12, 2019
Merged

mgr/test_orchestrator: Add dummy data#32182
sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp:upstream-pull-31757

Conversation

@sebastian-philipp
Copy link
Contributor

@sebastian-philipp sebastian-philipp commented Dec 11, 2019

  • Add a JSON file containing dummy data for testing the orchestrator.
  • .. and make sure, the data is not getting out of date.

Replaces #31757

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@votdev @sebastian-philipp
mgr/test_orchestrator: Add dummy data
f17de36 
Add a JSON file containing dummy data for testing the orchestrator.

Signed-off-by: Volker Theile <vtheile@suse.com>
@sebastian-philipp sebastian-philipp requested a review from a team as a code owner December 11, 2019 14:31
@sebastian-philipp sebastian-philipp mentioned this pull request Dec 11, 2019
Closed
3 tasks
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Dec 11, 2019

can be merged, as soon as make check is green

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Dec 11, 2019

failed.

ceph/deployment/inventory.py:8:1: E302 expected 2 blank lines, found 1
ceph/tests/test_inventory.py:7:1: E302 expected 2 blank lines, found 1
ceph/tests/test_inventory.py:10:101: E501 line too long (114 > 100 characters)
ceph/tests/test_inventory.py:13:1: E304 blank lines found after function decorator

@sebastian-philipp
python-common: Also test mgr/test_orchestrator/dummy_data.json
e8b40e6 
Make sure, `pybind/mgr/test_orchestrator/dummy_data.json` is not getting out of date.

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Dec 12, 2019

https://tracker.ceph.com/issues/43274

@sebastian-philipp
Copy link
Contributor Author

sebastian-philipp commented Dec 12, 2019

jenkins test make check

@sebastian-philipp sebastian-philipp merged commit 9242d53 into ceph:master Dec 12, 2019
@sebastian-philipp sebastian-philipp deleted the upstream-pull-31757 branch December 12, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@votdev votdev votdev approved these changes

Assignees

No one assigned

Labels

common orchestrator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sebastian-philipp @votdev