Skip to content

mgr/test_orchestrator: Add dummy data#31757

Closed
votdev wants to merge 1 commit intoceph:masterfrom
votdev:add_dummy_data
Closed

mgr/test_orchestrator: Add dummy data#31757
votdev wants to merge 1 commit intoceph:masterfrom
votdev:add_dummy_data

Conversation

@votdev
Copy link
Member

@votdev votdev commented Nov 20, 2019 •
edited
Loading

Add a JSON file containing dummy data for testing the orchestrator.

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@votdev votdev requested review from a team, bk201 and sebastian-philipp November 20, 2019 10:45
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Nov 20, 2019

Can you make use of it? Just adding the data seems a bit pointless

@votdev
Copy link
Member Author

votdev commented Nov 20, 2019 •
edited
Loading

Can you make use of it? Just adding the data seems a bit pointless

I can use it to test the Dashboard UI, but nothing more.

@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Nov 20, 2019

Can you make use of it? Just adding the data seems a bit pointless

I can use it to test the Dashboard UI, but nothing more.

What do you think about unifying this with

ceph/src/python-common/ceph/tests/test_inventory.py

Lines 6 to 8 in 2da7330

def test_from_json():
data = json.loads("""
[

?

@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Nov 27, 2019

Ping

@votdev votdev force-pushed the add_dummy_data branch 2 times, most recently from 9f85362 to 31248b6 Compare November 28, 2019 10:16
@votdev
mgr/test_orchestrator: Add dummy data
bbcbe7c 
Add a JSON file containing dummy data for testing the orchestrator.

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev mentioned this pull request Dec 4, 2019
Merged
3 tasks
@votdev
Copy link
Member Author

votdev commented Dec 4, 2019

jenkins test make check

@sebastian-philipp sebastian-philipp mentioned this pull request Dec 11, 2019
Merged
3 tasks
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Dec 11, 2019

can we close this in favor of #32182 ?

@votdev votdev closed this Dec 11, 2019
@votdev votdev deleted the add_dummy_data branch December 11, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bk201 bk201 Awaiting requested review from bk201

@sebastian-philipp sebastian-philipp Awaiting requested review from sebastian-philipp

Assignees

No one assigned

Labels

feature needs-review orchestrator

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@votdev @sebastian-philipp