ceph-daemon: only set up crash dir mount if it exists#31130
Merged
liewegas merged 1 commit intoceph:masterfrom Oct 25, 2019
Merged
ceph-daemon: only set up crash dir mount if it exists#31130liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
leseb
reviewed
Oct 24, 2019
Member
leseb
left a comment
There was a problem hiding this comment.
Shouldn't you have a task that creates all the Ceph dirs on the host instead of checking for an exception?
Member
Author
|
Whenever a daemon is deployed, we deploy the per-host crash agent too. But sometimes ceph-daemon runs on a pristine host, like when doing ceph-volume inventory. In that case, we should start the crash-agent (c-v doesn't crash the way daemons do). |
Member
Author
|
The only trace the c-v function leaves behind is creating the per-fsid log dir to capture the c-v logs. |
db3b2be to
e48d7e4
Compare
Sometimes we run containers on a host that doesn't have a crash dir set up (becuase no daemon has been deployed). Examples include shell and ceph-volume. Signed-off-by: Sage Weil <sage@redhat.com>
e48d7e4 to
f56a8db
Compare
Member
Author
|
test_ceph_daemon.sh passes |
sebastian-philipp
approved these changes
Oct 25, 2019
liewegas
added a commit
that referenced
this pull request
Oct 25, 2019
* refs/pull/31130/head: ceph-daemon: only set up crash dir mount if it exists Reviewed-by: Sebastian Wagner <swagner@suse.com>
tchaikov
reviewed
Oct 27, 2019
| which docker && ( $SUDO $CEPH_DAEMON --docker version | grep 'ceph version' ) | ||
|
|
||
| ## test shell before bootstrap, when crash dir isn't (yet) present on this host | ||
| $SUDO $CEPH_DAEMON shell -- ceph -v | grep 'ceph version' |
Contributor
There was a problem hiding this comment.
2019-10-26T17:29:42.004 INFO:tasks.workunit.client.0.mira109.stderr:+ sudo /usr/sbin/ceph-daemon shell -- ceph -v
2019-10-26T17:29:42.004 INFO:tasks.workunit.client.0.mira109.stderr:+ grep 'ceph version'
2019-10-26T17:29:42.149 INFO:tasks.workunit.client.0.mira109.stderr:the input device is not a TTY
2019-10-26T17:29:42.171 DEBUG:teuthology.orchestra.run:got remote process result: 1
@liewegas this test fails. /a//kchai-2019-10-26_15:51:16-rados-wip-kefu-testing-2019-10-26-1857-distro-basic-mira/4447747
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we run containers on a host that doesn't have a crash dir set
up (becuase no daemon has been deployed). Examples include shell and
ceph-volume.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docs