backport-resolve-issue: resolve multiple backport issues#30988
Merged
smithfarm merged 1 commit intoceph:masterfrom Oct 30, 2019
Merged
backport-resolve-issue: resolve multiple backport issues#30988smithfarm merged 1 commit intoceph:masterfrom
smithfarm merged 1 commit intoceph:masterfrom
Conversation
When multiple backports are concentrated into a single backport PR (a common practice), the script would only resolve the first one, which was an annoying shortcoming. In addition to implementing the feature, take the opportunity to pay some technical debt (put functions in alphabetical order, move code units into dedicated functions/methods, etc.). Signed-off-by: Nathan Cutler <ncutler@suse.com>
c19bf86 to
af43b3c
Compare
Contributor
Author
|
Note: I have been using this for some time now and it's working well. I think the PR is ready to merge. |
Contributor
Author
|
Oops, this introduced a regression. Follow-on PR: #31247 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple backports are concentrated into a single backport PR (a common
practice), the script would only resolve the first one, which was an annoying
shortcoming.
In addition to implementing the feature, take the opportunity to pay some
technical debt (put functions in alphabetical order, move code units into
dedicated functions/methods, etc.).
Signed-off-by: Nathan Cutler ncutler@suse.com