Skip to content

backport-resolve-issue: "recognize that Target version is populated" and "prune duplicate URLs"#31247

Merged
smithfarm merged 2 commits intoceph:masterfrom
smithfarm:wip-bri-regression
Oct 31, 2019
Merged

backport-resolve-issue: "recognize that Target version is populated" and "prune duplicate URLs"#31247
smithfarm merged 2 commits intoceph:masterfrom
smithfarm:wip-bri-regression

Conversation

@smithfarm
Copy link
Contributor

@smithfarm smithfarm commented Oct 30, 2019 •
edited
Loading

Due to a regression, the script stopped recognizing that a Backport tracker
issue's "Target version" field is populated.

Fixes: af43b3c
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm
backport-resolve-issue: recognize that Target version is populated
942e738 
Due to a regression, the script stopped recognizing that a Backport tracker
issue's "Target version" field is populated.

Fixes: af43b3c
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm requested a review from theanalyst October 30, 2019 10:47
@smithfarm smithfarm mentioned this pull request Oct 30, 2019
Merged
@smithfarm
backport-resolve-issue: prune duplicate URLs
49ab751 
I have seen PR descriptions with a single backport tracker URL mentioned twice.
When backport-resolve-issue hit one of these, it would say:

Found backport tracker: https://tracker.ceph.com/issues/39272
Found backport tracker: https://tracker.ceph.com/issues/39272
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR ceph#29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR ceph#29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
=================================================================

This commit fixes the issue.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm changed the title backport-resolve-issue: recognize that Target version is populated backport-resolve-issue: "recognize that Target version is populated" and "prune duplicate URLs" Oct 30, 2019
@theanalyst
Copy link
Member

theanalyst commented Oct 31, 2019 •
edited
Loading

I ran this on the luminous branch and works great!

NFO:root:Redmine key was provided; using it
INFO:root:Current git branch is luminous, v12.2.12
INFO:root:Ceph release is luminous
INFO:root:Starting from merge commit ['763a732ec1']
INFO:root:Commit range is 763a732ec1..HEAD
INFO:root:I see 2 merge(s) to process


=================================================================
GitHub PR URL:    https://github.com/ceph/ceph/pull/30242
GitHub PR title:  luminous: cephfs: client: return -EIO when sync fi|TRUNCATED
Merge commit:     ca6233676d368600b083b2d544eb87793d591627 (v12.2.12-640-gca6233676d)
Merged:           True
Ceph version:     base v12.2.12, target v12.2.13
Found backport tracker: https://tracker.ceph.com/issues/41489
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/41489 links to PR https://github.com/ceph/ceph/pull/30242
INFO:root:Backport Tracker 41489 target version not populated yet!
INFO:root:Backport Tracker 41489 status is currently set to In Progress
=================================================================
[a] Abort, [i] Ignore and advance BRI-luminous tag, [u] Update tracker and advance BRI-luminous tag (default 'u') --> u
Merges remaining to process: 1


=================================================================
GitHub PR URL:    https://github.com/ceph/ceph/pull/31257
GitHub PR title:  luminous: doc: update bluestore cache settings and|TRUNCATED
Merge commit:     5ff3e8ea3dc0742fe90b3b8581c58198beb7d3d4 (v12.2.12-642-g5ff3e8ea3d)
Merged:           True
Ceph version:     base v12.2.12, target v12.2.13
Found backport tracker: https://tracker.ceph.com/issues/41289
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/41289 links to PR https://github.com/ceph/ceph/pull/31257
INFO:root:Backport Tracker 41289 target version not populated yet!
INFO:root:Backport Tracker 41289 status is currently set to In Progress
=================================================================
[a] Abort, [i] Ignore and advance BRI-luminous tag, [u] Update tracker and advance BRI-luminous tag (default 'u') --> u
Merges remaining to process: 0

@smithfarm smithfarm merged commit 14cdd8e into ceph:master Oct 31, 2019
@smithfarm smithfarm deleted the wip-bri-regression branch October 31, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theanalyst theanalyst theanalyst approved these changes

Assignees

No one assigned

Labels

bug-fix tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smithfarm @theanalyst