mgr: use new MMgrCommand for CLI commands sent to mgr#30155
Merged
liewegas merged 3 commits intoceph:masterfrom Sep 10, 2019
Merged
mgr: use new MMgrCommand for CLI commands sent to mgr#30155liewegas merged 3 commits intoceph:masterfrom
liewegas merged 3 commits intoceph:masterfrom
Conversation
neha-ojha
reviewed
Sep 5, 2019
MCommand is used both for tell-style commands and for CLI commands implemented by the mgr. Allow the latter to be send via MMgrCommand instead. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
This allows us to (eventually) leave MCommand for tell-style commands only. Signed-off-by: Sage Weil <sage@redhat.com>
76ae52b to
274973d
Compare
274973d to
0019005
Compare
neha-ojha
approved these changes
Sep 6, 2019
9 tasks
liewegas
added a commit
that referenced
this pull request
Sep 10, 2019
* refs/pull/30155/head: mgr/MgrClient: send MMgrCommand for octopus+ mgrs mon/MgrMap: include mgr_features in mgrmap mgr: accept MMgrCommand[Reply] messages (in addition to MCommand[Reply]) Reviewed-by: Neha Ojha <nojha@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have
Our goal is to unify the tell and daemon commands, and to keep them distinct from CLI commands (ceph pg ls != ceph tell mgr.x pg ls). This is the first step in that process. (Next steps will include using MCommand for mon tell commands, and then actually unifying the daemon and tell command handling for each daemon.)
(I didn't just use MMonCommand for CLI commands to mon because MMonCommand derives from PaxosServiceMessage, and that doesn't seem appropriate for the mgr.)