Conversation
src/pybind/rados.py
Outdated
Member
There was a problem hiding this comment.
it'll always return 0, so I'd suggest leaving out the return value from the python wrappers for all these wait_for_* functions
Member
Author
|
Rebased on master; added new commits for review comments and to add a separate test for "wait_for_complete_and_cb()". I'll squash the middle commit before push once you get a chance to look, Josh. |
Also modify aio_read test for wait: write an object, take its active set down, try to aio_read; verify read doesn't complete until active set is allowed back up Fixes: #10104 Signed-off-by: Dan Mick <dan.mick@redhat.com>
Also, factor out some common code between the two tests Signed-off-by: Dan Mick <dan.mick@redhat.com>
jdurgin
added a commit
that referenced
this pull request
Dec 4, 2014
rados.py: fix misnamed 'wait_*' routines, add true wait/wait-with-cb Reviewed-by: Josh Durgin <jdurgin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also modify aio_read test for wait: write an object, take its active set
down, try to aio_read; verify read doesn't complete until active set is
allowed back up
Fixes: #10104
Signed-off-by: Dan Mick dan.mick@redhat.com