rgw: Evaluating bucket policies also while reading permissions for an…#27309
Merged
cbodley merged 1 commit intoceph:masterfrom Apr 9, 2019
Merged
Conversation
… object that is non-existent. Fixes http://tracker.ceph.com/issues/38638 Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
adamemerson
approved these changes
Apr 2, 2019
Contributor
Author
|
teuthology results show that this PR doesn't seem to have caused any failure : http://pulpito.ceph.com/prsrivas-2019-04-04_08:31:45-rgw-wip-rgw-non-existent-object-distro-basic-smithi/ |
3 tasks
ludwigschwardt
added a commit
to ska-sa/katdal
that referenced
this pull request
Nov 21, 2019
A 401 (Unauthorized) now results in a more specific AuthorisationFailed exception. The current MeerKAT Ceph RADOS Gateway actually returns a 403 for missing chunks and other objects (like the 'complete' marker). This is due to a bug in the interaction with bucket policy - see the discussion at https://tracker.ceph.com/issues/38638 and the resulting PR at ceph/ceph#27309 for a possible future resolution. Turn both 403 and 404 into ChunkNotFound if the object in question was expected to live within a bucket. Missing buckets are actually worse and leads straight to StoreUnavailable. This addresses JIRA ticket SPR1-181.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… object that is non-existent.
Fixes http://tracker.ceph.com/issues/38638
Signed-off-by: Pritha Srivastava prsrivas@redhat.com